Opened 18 years ago

Closed 17 years ago

#1892 closed defect (fixed)

Use getExpressionString/getFilterString/getTextString in PHP MapScript

Reported by: dmorissette Owned by: dmorissette
Priority: high Milestone: 5.0 release
Component: MapScript-PHP Version: 4.10
Severity: normal Keywords:
Cc:

Description (last modified by dmorissette)

In bug 1428 it was pointed out that SWIG MapScript has:

- class.getExpressionString()
- layer.getFilterString()
- label.getTextString()

and PHP MapScript has:

- class.getExpression()
- layer.getFilter()
- missing label.getTextString()

We should synchronize both interfaces in 5.0.

Would it make more sense to add the String suffix in PHP, or to remove it in the
SWIG wrappers? Note that in both SWIG and PHP, the set*() methods don't have the
string suffix (i.e. setFilter(), setExpression(), etc.)

Change History (4)

comment:1 by dmorissette, 18 years ago

Milestone: 5.0 release

comment:2 by sdlime, 18 years ago

One correction, getTextString is a class method...

As for naming, I think we chose the string suffix to inform users that it 
wasn't an expressionObj per se, but the string you'd use to build one. That 
probably isn't that important a distinction.

Steve

comment:3 by dmorissette, 17 years ago

Description: modified (diff)
Owner: changed from mapserverbugs to dmorissette

Checking this one...

comment:4 by dmorissette, 17 years ago

Resolution: fixed
Status: newclosed

Fixed in r6601: Added class.getTextString() and deprecated/renamed class.getExpression() and layer.getFilter() to class.getExpressionString() and layer.getFilterString() to match what we have in SWIG MapScript

Note: See TracTickets for help on using tickets.