Opened 18 years ago

Closed 17 years ago

#1867 closed defect (fixed)

dylib checks missing for many libs in configure

Reported by: kyngchaos@… Owned by: hobu
Priority: high Milestone: 5.0 release
Component: Build Problems Version: 4.8
Severity: normal Keywords:
Cc:

Description (last modified by hobu)

No libraries are checked for the presence of a dylib (Mac OS X).  These ones fail if a static library is not 
present:

png
jpeg
gd
proj
pdf
Xpm

The check fails even if explicit dirs are set using --with options.  Other libraries skip the check for 
library files if a --with option is used to set the dir, but still may fail if the --with option doesn't specify 
a dir because they also don't check for dylibs:

freetype
tiff

these ones work since they are in /usr/lib (which is handled separately in configure) on OS X:

zlib
iconv

Others I haven't tried on OSX (mpatrol), or just don't exist on OSX (SDE).

Change History (12)

comment:1 by dmorissette, 18 years ago

Cc: mapserver-bugs@… added
Milestone: 4.10 release
Owner: changed from mapserverbugs to dmorissette
Setting 4.10 release target milestone.

comment:2 by hobu, 18 years ago

Cc: hobu@… added

comment:3 by hobu, 18 years ago

Status: newassigned

comment:4 by hobu, 18 years ago

I have added .dylib checks for all of these libraries.  Please confirm.

comment:5 by kyngchaos@…, 18 years ago

Oops, you left off the 'lib' subfolder from the png check:

test -f $PNG_DIR/lib/libpng.a -o -f $PNG_DIR/lib/libpng.so -o -f $PNG_DIR/lib/libpng.sl -o -f 
$PNG_DIR/libpng.dylib && PNG_LIBDIR="$PNG_DIR/lib"

Should be: $PNG_DIR/lib/libpng.dylib

One other thing, some of the checks list the various forms when they fail.  ie:

echo "$as_me:$LINENO: result: \"Could not find jpeglib.h or libjpeg.a/libjpeg.so in $JPEG_DIR.\"" >&5

For completeness, .dylib should be added to those, or they should be changed to a more generic 
'libwhatever could not be found'.

comment:6 by hobu, 18 years ago

fixed

comment:7 by dmorissette, 18 years ago

Cc: dmorissette@… added
Owner: changed from dmorissette to hobu@…
Status: assignednew
Assigned to Howard since you've taken care of this one already. Thanks.

comment:8 by kyngchaos@…, 18 years ago

png check is working now.

comment:9 by hobu, 18 years ago

Status: newassigned
I didn't go through and add notes for things like 

echo "$as_me:$LINENO: result: \"Could not find jpeglib.h or libjpeg.a/libjpeg.so
in $JPEG_DIR.\"" >&5  

I agree that they should probably be changed to something generic and should be
broken into *two* warnings.  It isn't specific enough as it currently is
anyway...which one is missing, the header or the lib?

comment:10 by hobu, 17 years ago

Description: modified (diff)

William,

Are things behaving with this now?

Howard

comment:11 by kyngchaos, 17 years ago

As far as checking dylibs, it's working. The warning messages that say .a/.so still need to be changed, but that's not a showstopper.

comment:12 by hobu, 17 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.