mapObj.nextLabel() can be used only once

[eugoss@…]

As mapObj.nextLabel() contains a static variable in its body (see below), it cannot be invoked several times to retrieve labelCacheMemberObj objects of a map. And due to the same reason, it cannot be used in multithreaded environment.

Is it possible to implement something like labelCacheObj.getLabel(index) to access labelCacheMemberObj objects through mapObj.labelcache or modify nextLabel() to allow at least to reset an index in it?

By the way, there is already labelCacheObj.labels holding all labelCacheMemberObj objects. It could be nice to have a couple of set/get for it.

// nextLabel() in question
static labelCacheMemberObj *nextLabel(mapObj *self) {
    static int i = 0;
    if (i < self->labelcache.numlabels)
        return &(self->labelcache.labels[i++]);
    else
        return NULL;
}

[eugoss@…]

mapscript/swiginc/map.i

[sdlime]

This is a reasonable solution. I'll patch Swig/MapScript and have CC'd Assefa 
for PHP...

Steve

[eugoss@…]

Thank you very much.

[sdlime]

This has been committed to CVS head so SWIG/MapScript is ok now. Re-assigning to
PHP/MapScript component.

Steve

[dmorissette]

I'll take this bug. The issue of nextLabel() vs getlabel(i) has come up again while working on the label priority (RFC-27).

[aboudreault]

The method map::getLabel has been added in PHP mascript in r9744. The documentation has been updated in r9746.

[aboudreault]

jmckenna, may you review my documentation update to check if it's ok ? (r9746 and r9747)

[jmckenna]

ok will review updated docs