Opened 18 years ago
Closed 17 years ago
#1729 closed defect (fixed)
[OGC:SOS] Warnings missing from GetCapabilities
Reported by: | Owned by: | assefa | |
---|---|---|---|
Priority: | highest | Milestone: | |
Component: | SOS Server | Version: | unspecified |
Severity: | normal | Keywords: | |
Cc: | tomkralidis, dmorissette |
Description (last modified by )
when required metadata is missing no warning is returned by GetCapabilities. WMS and missing metadata: <!-- WARNING: Mandatory metadata ... was missing in this context. -->
Change History (6)
comment:2 by , 17 years ago
Cc: | added |
---|
comment:3 by , 17 years ago
Most required mapfile metadata that is missing for mapogcsos.c will return a service exception because of the way OGC:SOS works, so I think we're okay there.
As for the rest of OGC:SOS GetCapabilities, since mapogcsos.c calls mapowscommon.c for these XML, I've skimmed through OWS Common 1.0.0. Most metadata elements are optional. Only _contactorganization is a required element.
I've put logic in mapowscommon.c to provide a warning for _contactorganization because it's required. Do we want the same for optional OWS Common metadata which is not set in the mapfile? If yes, I will update and commit for all mapfile generated metadata in mapowscommon.c. If no, I will commit the fix for _contactorganization.
Please advise.
comment:4 by , 17 years ago
Cc: | added |
---|---|
Description: | modified (diff) |
comment:5 by , 17 years ago
I don't think we have produced warnings for optional metadata in the past, at least I think that's true for WMS. I think I used to put warnings only for required items such as layer title or SRS. In those cases when information is missing MapServer tried to set a suitable default and issued a Warning. If it was not possible to set a default value then MapServer would produce an exception.
Oh, I think I also put warnings for things that were becoming a FAQ because lots of users would repeat the same mistake (I don't have any example in mind right now but I seem to remember doing that.)
In summary, there is no hard rule to decide whether warnings are required or not... just ask yourself whether as a user a warning would be useful or not in a situation where a given piece of information is missing.
comment:6 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
I've added tests for all mapfile metadata (required / optional) used in mapowscommon.c (r6123).
Closing this ticket.