Ticket #1437 (closed defect: fixed)

Opened 3 years ago

Last modified 1 year ago

Change main header file name (or provide alternative)

Reported by: andrew.bell.ia@gmail.com Assigned to: dmorissette
Priority: high Milestone: 5.0 release
Component: Build Problems Version: unspecified
Severity: normal Keywords:
Cc: sgillies@frii.com

Description (Last modified by dmorissette)

map.h was used to store C++ library map data structure definitions before the standard became formal and still exists on many systems. This can cause a conflict which searching for the mapserver map.h file. Suggest renaming map.h, or providing an alternative file (mapserver.h, perhaps) which would simply include a well-specified map.h to avoid naming conflicts: 

#ifndef MAPSERVER_H
#define MAPSERVER_H

#include "./map.h"

#endif

Change History

08/09/05 14:43:18 changed by dmorissette

  • owner changed from mapserverbugs to dmorissette@dmsolutions.ca.
  • cc set to hobu@iastate.edu, warmerdam@pobox.com, sgillies@frii.com, steve.lime@dnr.state.mn.us, mapserver-bugs@dmsolutions.ca.
I have always feared that the name map.h was a bit too generic and could
eventually cause conflicts.

I think renaming it to something like mapserver.h might be best, unless we're
worried that this could possibly cause confusions with the already existing
mapserv.h.

Adding other developers to CC to get their thoughts.

08/09/05 15:32:49 changed by sdlime 

mapserver.h sounds fine to me. I can't see why changing that would impact users 
at all. - Steve

08/09/05 15:59:11 changed by fwarmerdam 

I am ok with changing it to mapserver.h, but I can't help but wonder if there
is any other rationalization we ought to do at the same time.

05/22/07 18:15:05 changed by hobu

  • description changed.
  • milestone set to 5.0 release.

Should we revisit this change for the 5.0 release? Any external clients using MapServer through C would be affected, but all of the mapscripts could be changed without much trouble.

06/08/07 08:34:29 changed by dmorissette

  • description changed.

07/23/07 22:41:12 changed by dmorissette

  • status changed from new to closed.
  • resolution set to fixed.

It has been decided by vote of the PSC on the -dev list to rename map.h -> mapserver.h.

This change has been committed to SVN in r6373 (v4.99). Closing ticket.