Opened 19 years ago

Closed 16 years ago

#1181 closed defect (fixed)

[PATCH] Make function prototypes ANSI C

Reported by: pere@… Owned by: mapserverbugs
Priority: high Milestone:
Component: Build Problems Version: 4.4
Severity: normal Keywords:
Cc: tomkralidis

Description (last modified by dmorissette)

Adding more warnings, pinpoint several places in the code where '()'
is used to indicate functions without arguments.  In ANSI C, '(void)'
is the correct way to specify this, and the code in question specifies
a function with an unspecified list of arguments, not a function
without arguments.  The compiler emits this message for the code in
question:

  warning: function declaration isn't a prototype

The attached patch get rid of all these warnings.

Attachments (1)

ansi-prototypes.diff (12.0 KB ) - added by pere@… 19 years ago.
Make code use ANSI C prototypes.

Download all attachments as: .zip

Change History (4)

by pere@…, 19 years ago

Attachment: ansi-prototypes.diff added

Make code use ANSI C prototypes.

comment:1 by pere@…, 19 years ago

The patch is applied to CVS:

2005-01-28 07:16  sdlime

        * map.h, maperror.c, mapfile.c, maplexer.l, mapogcfilter.c,
          mapogcfilter.h, mapparser.y, mapraster.c, mapserv.c, mapsymbol.c,
          mapthread.h, maptime.h, maputil.c, mapwfslayer.c, sortshp.c,
          tile4ms.c: Applied patch to make function prototypes ANSI C
          compliant. Thanks to Petter Reinholdtsen. This fixes but 1181.


comment:2 by tomkralidis, 16 years ago

Cc: tomkralidis added

Bump. Can we close this one?

comment:3 by dmorissette, 16 years ago

Description: modified (diff)
Resolution: fixed
Status: newclosed

I think so. Marking fixed.

Note: See TracTickets for help on using tickets.