msWMSGetFeatureInfoURL : the info_format should be optional

[assefa]

msWMSGetFeatureInfoURL(mapObj *map, layerObj *lp,
                             int nClickX, int nClickY, int nFeatureCount,
                             const char *pszInfoFormat

The pszInfoFormat should be optional since in wms 1.1.1 GetFeatureInfo 
request, the info_format is optional :

 See alslo Bug 1169 related to this.

[dmorissette]

I don't have the WMS spec with me to check, but it doesn't seem to make sense to
not include the info_format in a GetFeatureInfo request. Not including it would
lead to unpredictable behavior.

[assefa]

This is from wms 1.1.1

7.3.3.6 INFO_FORMAT
The optional INFO_FORMAT indicates what format to use when returning the feature
information. Supported values for a GetFeatureInfo request on a WMS instance are
listed
as MIME types in one or more <Format> elements inside the <Request><FeatureInfo>
element of its Capabilities XML. The entire MIME type string in <Format> is used as
the value of the INFO_FORMAT parameter. In an HTTP environment, the MIME type
shall be set on the returned object using the Content-type entity header.

[dmorissette]

Um... perhaps we should make it optional just to map to the WMS spec, but I
think that in practice it is a bad idea to not specify the format since that
opens the possibility of unpredictable results.

[tomkralidis]

I would agree with Daniel. Although INFO_FORMAT is optional from a WMS Server point of view, we can enforce it as a client. In other words, I don't think we are penalized if we force INFO_FORMAT from a client perspective.

Comments? Objections to marking this wontfix?

[dmorissette]

I vote WONTFIX but would like to hear what Assefa thinks before we close the ticket.

Also note that in WMS 1.3.0, INFO_FORMAT has become mandatory.

[tomkralidis]

Assefa: comments here?

[assefa]

Agreed : It can be marked as won't fix.