GetLegendGraphic and Layers with status not defined

[bartvde@…]

When issuing a GetLegendGraphic request on a layer without a status defined, no
legend is displayed. If you issue a GetMap request on the layer, the Mapserver
code probably turns the status of the layer to on so that it is displayed.

Maybe this should also be changed for the GetLegendGraphic code, or maybe there
should be a more general WMS or OWS mechanism for doing this?

[bartvde@…]

Added mapserver-bugs@dmsolutions.ca to the cc to see what they think about this.

[bartvde@…]

Setting target to future.

[jmckenna@…]

i was recently testing getlegendgraphic for the docs, and was baffled why one
layer would not return a legendgraphic...it was in fact turned OFF in the server
mapfile.  I think this issue should be fixed to follow the getmap functionality,
as Bart mentioned.

[bartvde@…]

Running into this again, we really need to get this fixed. This should be such
an easy fix, I could even do it if I had CVS commit rights ...

In mapwms.c:

         for (i=0; i<map->numlayers; i++)
         {
             if (map->layers[i].name &&
                 strcasecmp(map->layers[i].name, pszLayer) != 0)
             {
                 map->layers[i].status = MS_OFF;
             }
         } 

Change the above to:

         for (i=0; i<map->numlayers; i++)
         {
             if (map->layers[i].name &&
                 strcasecmp(map->layers[i].name, pszLayer) != 0)
             {
                 map->layers[i].status = MS_OFF;
             }
             else if (strcasecmp(map->layers[i].name, pszLayer) == 0)
             {
                 map->layers[i].status = MS_ON;
             }
         }

I have tested this fix in my local copy. Can somebody please commit this?

[bartvde@…]

To be on the safe side, also add a check on the name being set:

             else if (map->layers[i].name && strcasecmp(map->layers[i].name,
pszLayer) == 0)
             {
                 map->layers[i].status = MS_ON;
             }

[bartvde@…]

Reading over it again, the second check is pretty useless now, so:

             else if (map->layers[i].name)
             {
                 map->layers[i].status = MS_ON;
             }

[dmorissette]

Taking this one.

[dmorissette]

Fixed in CVS HEAD (4.7) and branch-4-6 (will be in 4.6.1).

There was already a loop searching for the layer by name, so to avoid two loops
of strcasecmp() on layer names, I changed the second one to:

         /* turn this layer on and all other layers off, required for
msDrawLegend() */
         for (i=0; i<map->numlayers; i++)
         {
             if (i == iLayerIndex)
                 map->layers[i].status = MS_ON;
             else
                 map->layers[i].status = MS_OFF;
         }