Ticket #112 (closed defect: fixed)

Opened 11 years ago

Last modified 10 years ago

PHP MapScript Makefile shouldn't use GNUmake features

Reported by: dmorissette Owned by: dmorissette
Priority: high Milestone:
Component: MapScript-PHP Version: 4.0
Severity: normal Keywords:
Cc:

Description

Pushkar Pradhan wrote:
> 
> This creates the makefile but when I do a make I get the foll. error:
> cd mapscript/php3; make; cd ../..
> make: Fatal error in reader: Makefile, line 69: Badly formed macro
> assignment
> Current working directory
> /rstc/user1/erc/pushkar/mapserver_3.5/mapscript/php3
> *** Error code 1
> make: Fatal error: Command failed for target `php3_mapscript'
> Actually the error occurs on line 69 of the Makefile in mapscript/php dir.
> This line is:
> CFLAGS := $(CFLAGS) $(MS_DEFINE) $(MS_INC) $(PHP_INC)


If I remember well, ":=" is supported only by GNUMake... and changing
the above statement to use "=" won't work because the old value of
CFLAGS is reassigned to itself.  I'll file a bug in bugzilla about
fixing the makefiles so that they don't rely on GNUMake features, but in
the meantime your can either install GNUmake or edit the statement above
to be:

CFLAGS = -O2  -Wall -DCOMPILE_DL=1 -DPHP4 $(MS_DEFINE) $(MS_INC) \
         $(PHP_INC)

Change History

Changed 10 years ago by dmorissette

  • status changed from new to closed
  • version changed from 3.6 to 4.0
  • resolution set to fixed
Fixed in 4.0 makefile.  I replaced the "CFLAGS := $(CFLAGS) ..." with a new 
variable called CFLAGS112:  "CFLAGS112 = $(CFLAGS) ..."
Note: See TracTickets for help on using tickets.