Opened 10 years ago

Closed 9 years ago

#966 closed defect (fixed)

Apache conf has incorrect path

Reported by: martinmorrison Owned by: jng
Priority: low Milestone: 2.1
Component: Installer Version: 2.1.0
Severity: trivial Keywords:
Cc: jng, jbirch External ID:

Description

In the Apache conf file, line 57 should NOT have a slash at the end...

ServerRoot? "C:/Program Files/OSGeo/MapGuide Web/Apache2/"

Change History (7)

comment:1 Changed 10 years ago by jbirch

Cc: jng jbirch added
Milestone: 2.1

What are the effects of this setting having a trailing slash?

One of the problems with the installer technology is that the properties are set with trailing slashes and there is no way (short of a custom action) to do string manipulation on the properties.

We could work around this by making the names "Web" and "Server" non-configurable, and basing the Apache config off of MAPGUIDEROOTLOCATION. I'm actually in favour of reducing the number of public properties in the installer, so this might not be a bad approach.

comment:2 Changed 10 years ago by jbirch

BTW, current structure:

[ProgramFiles?]/OSGeo/MapGuide/Server [ProgramFiles?]/OSGeo/MapGuide/Web

with "MapGuide" being the install base, and configurable. To hard-code the Server and Web folders, we'd only have to change the property names to mixed-case, and remove the attribute from the server and web features that allows them to be configurable in the UI.

comment:3 Changed 10 years ago by martinmorrison

Items that reference a path relative to the root will have an extra slash.

comment:4 in reply to:  1 Changed 10 years ago by jng

Owner: set to jng
Status: newassigned

We already are using a custom action to do this writing, it just means we have to strip the trailing slash from the Apache dir, and adjust the httpd.conf template to match.

Replying to jbirch:

What are the effects of this setting having a trailing slash?

One of the problems with the installer technology is that the properties are set with trailing slashes and there is no way (short of a custom action) to do string manipulation on the properties.

We could work around this by making the names "Web" and "Server" non-configurable, and basing the Apache config off of MAPGUIDEROOTLOCATION. I'm actually in favour of reducing the number of public properties in the installer, so this might not be a bad approach.

comment:5 Changed 9 years ago by jng

Resolution: fixed
Status: assignedclosed

Fixed in r3853

comment:6 Changed 9 years ago by jng

Resolution: fixed
Status: closedreopened

tomcat.conf does not have these changes. ie. Java configuration is broken out of the box

comment:7 Changed 9 years ago by jng

Resolution: fixed
Status: reopenedclosed

Fixed in trunk (r3893) Fixed in 2.1 branch (r3895)

Note: See TracTickets for help on using tickets.