Ticket #508 (closed task: fixed)

Opened 5 years ago

Last modified 5 years ago

Remove string members in render styles

Reported by: waltweltonlair Owned by: waltweltonlair
Priority: medium Milestone: 2.1
Component: General Version: 2.0.0
Severity: minor Keywords:
Cc: External ID: 1064832

Description

The SE_RenderStyle derived structs contain a number of string members (e.g. angleControl, vertexControl), and the rendering code uses string comparison calls to branch based on their values. This all happens inside the rendering loop. A more efficient implementation is to use enumerated types in place of these string members. In the common case (no expressions) the strings are then evaluated only once when the style is evaluated.

Change History

Changed 5 years ago by waltweltonlair

  • status changed from new to assigned

Another benefit to doing this is that schema-specific behavior (such as handling of deprecated and default values) is less spread out.

Changed 5 years ago by waltweltonlair

  • status changed from assigned to closed
  • resolution set to fixed

Changed 5 years ago by waltweltonlair

  • external_id set to 1064832

Changed 5 years ago by waltweltonlair

Merged fix into branch stream with submission  https://trac.osgeo.org/mapguide/changeset/3130.

Note: See TracTickets for help on using tickets.