Opened 12 years ago

Closed 11 years ago

#4 closed defect (fixed)

tile egde effects with raster layers

Reported by: pagameba Owned by: traianstanev
Priority: high Milestone: 1.2
Component: Tile Service Version: 1.1.0
Severity: critical Keywords:
Cc: External ID: 839964

Description

When using raster data sources in tiled maps, the edges of the tiles sometimes have a single pixel border on some or all edges of some tiles. This appears to be a rounding error in the code that requests the tile from the FDO provider since the same error occurs with both the ADSK raster provider and the GDAL raster provider.

Tom said on the list:

Hi Paul,

This is a problem with the tiling code when it creates a tile with a raster (using the Autodesk raster provider or the GDAL provider). I debugged into this a while back and it looks like either: 1) the extracted image (from the source feature source) used to create the tile is sometimes offset incorrectly (like you say, this is a rounding error) and/or 2) the image is not being stretched to fill the whole area of the tile (GDRenderer.cpp line 553, has comment TODO: do we need +1?).

I tried #2 but the lines still came up a bit faded. Someone with more time is going to have to look into this.

Tom

Change History (11)

comment:1 Changed 12 years ago by Tom Fukushima <tom.fukushima@…>

External ID: 839964

Added External ID.

comment:2 Changed 12 years ago by anonymous

Owner: set to anonymous
Status: newassigned

comment:3 Changed 12 years ago by anonymous

Owner: changed from anonymous to traianstanev
Status: assignednew

comment:4 Changed 12 years ago by anonymous

Resolution: fixed
Status: newclosed

comment:5 Changed 12 years ago by pagameba

Traian, I read your commit comments where you mentioned the last row might not be filled in ... does this also apply to the vertical edge effects? You also said 'Maybe fix ticket #4 ...' ... should we close this ticket if we are not sure?

comment:6 Changed 12 years ago by anonymous

It looks fixed. The transform code and image draw code had changed since this bug was reported, so I didn't see any vertical lines. The reason I'm not sure is because the code change affects too many things for me to fully test. It just needs more testing. If the bug is still there, the ticket can be reopened.

comment:7 Changed 12 years ago by pagameba

Thanks Traian, I'll try to come up with some way of testing this.

comment:8 Changed 12 years ago by tomfukushima

Paul, This fix will be in the MGOS 1.2 beta scheduled for next Monday.

comment:9 Changed 11 years ago by anonymous

now leverages Spring's wow gold? interface for generating a unique bean name for the anynomous top-level beans provided by a namespace handler [fixes #498]; updated spring.jar and springsrc.zip of the upcoming release 2.0.3 to the current head version

comment:10 Changed 11 years ago by jbirch

Resolution: fixed
Status: closedreopened

comment:11 Changed 11 years ago by jbirch

Resolution: fixed
Status: reopenedclosed

Darn, thought I could delete spam comments as admin. Sorry.

Note: See TracTickets for help on using tickets.