Opened 6 years ago

Closed 6 years ago

#1983 closed defect (fixed)

MapTip command uses hard-coded button position

Reported by: jng Owned by:
Priority: low Milestone: 2.4
Component: AJAX Viewer Version:
Severity: trivial Keywords:
Cc: trevorwekel External ID:

Description

The maptip command uses a hard-coded toolbar button position of 14 (to set the enabled/disabled state).

This is obviously bad as adding any toolbar command that displaces the maptip command from its position will cause the maptip command to "toggle" the wrong button.

The fix is to record the indices of the maptip toolbar buttons during initialization and use these indices to locate the toolbar buttons to enable/disable

Attachments (1)

getmaptip.patch (1.2 KB) - added by trevorwekel 6 years ago.
patch to fix web layout intiial load if no toolbar is present

Download all attachments as: .zip

Change History (4)

comment:1 Changed 6 years ago by jng

Resolution: fixed
Status: newclosed

Fixed trunk r6573 and 2.4 branch r6574

comment:2 Changed 6 years ago by trevorwekel

Cc: trevorwekel added
Resolution: fixed
Status: closedreopened

If the toolbar is not present, the call to GetMapTipButtons() will not exist. A patch to ajaxmappane.templ is attached.

To reproduce, turn off the Map Pane Toolbar in any of the Sheboygan web layouts. Before the patch, the map does not zoom to the correct extents on initial load.

Changed 6 years ago by trevorwekel

Attachment: getmaptip.patch added

patch to fix web layout intiial load if no toolbar is present

comment:3 Changed 6 years ago by jng

Resolution: fixed
Status: reopenedclosed

Patch applied trunk (r6742) and 2.4 (r6741)

Note: See TracTickets for help on using tickets.