Changeset 3219

Timestamp:

06/20/08 17:28:55 (5 months ago)

Author:

tomfukushima

Message:

#378 AJAX viewer does not load map in Firefox 3

For posts, FF3 sends "application/x-www-form-urlencoded; charset=UTF-8" as the content type. FF2 and other browsers send "application/x-www-form-urlencoded". The code does an exact string match on the latter string and so fails for FF3. This subsequently causes an unhandled exception that will cause Apache to crash.

The fix is to stop doing the extract string match and now just search for the "application/x-www-form-urlencoded" at the start of the ContentType? string. The fix needs to be applied in 3 places, the apache module, the plain cgi agent and the ISAPI agent.

Very easy fix to find, pretty much anyone with a debugger could probably have figured this out. It was just a matter of breaking at the exception and then following the stack to the method that had the bad code.

Files:

• trunk/MgDev/Web/src/ApacheAgent/ApachePostParser.cpp (modified) (2 diffs)
• trunk/MgDev/Web/src/CgiAgent/CgiPostParser.cpp (modified) (1 diff)
• trunk/MgDev/Web/src/IsapiAgent/IsapiPostParser.cpp (modified) (2 diffs)

trunk/MgDev/Web/src/ApacheAgent/ApachePostParser.cpp

@@ -91 +91 @@
-    }
-
- == MapAgentStrings::UrlEncoded
+.find(MapAgentStrings::UrlEncoded) == 0
-    {
-        m_pBuffer[totalBytes] = '\0';
@@ -168 +168 @@
-
-
+

trunk/MgDev/Web/src/CgiAgent/CgiPostParser.cpp

@@ -123 +123 @@
-        DumpMessage("Content type: %s", content.c_str());
-
- == MapAgentStrings::UrlEncoded
+.find(MapAgentStrings::UrlEncoded) == 0
-        {
-            m_buf[nBytes] = '\0';

trunk/MgDev/Web/src/IsapiAgent/IsapiPostParser.cpp

@@ -118 +118 @@
-    string content = m_pECB->lpszContentType;
-
- == MapAgentStrings::UrlEncoded
+.find(MapAgentStrings::UrlEncoded) == 0
-    {
-        m_pBuffer[dwTotalBytes] = '\0';  // null terminate
@@ -195 +195 @@
-
-
+