Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#219 closed defect (fixed)

enabling FI from TreeGDE does not work

Reported by: rwoita Owned by: nimix
Priority: major Milestone: 2.5 release
Component: treeGDE Version: 2.5 rc5
Keywords: Cc: nimix

Description

look up following discussion on nabble.com :

http://www.nabble.com/MB-2.5-RC2---treeGDE-featureinfo1---2nd-to16874453.html

Change History (16)

comment:1 by mschulz, 16 years ago

Version: 2.5 rc2

setting the version to 2.5rc2

comment:2 by mschulz, 16 years ago

Cc: nimix added
Component: user interfacetreeGDE

Just going through the code (realizing there have been profound changes ;-)) i found, that when changing only the querylayer status of a layer, mb_restateLayers is not called, thus the querylayers array is not updated. Adding a call the handleSelection as when changing visibility does the trick, but i'm not sure if this is correct or the intended usage of this function.

btw. also changed the component to treeGDE

comment:3 by christoph, 16 years ago

apparently a function handleLayer of the WMS object is called...however, this function does nothing. The obscure code makes it impossible to debug.

comment:4 by nimix, 16 years ago

I did some investigation today and the problem seems to be that the call of mb_restateLayers is missing. If you change the FI-Checkboxes and change the visibility of a layer afterwards the FI-Selection works

comment:5 by nimix, 16 years ago

unfortunately I don't have my test evironement now, but as far as I can see the treefolder2.php from nimix_dev branch does it the right way.

comment:6 by nimix, 16 years ago

Owner: changed from mapbender_dev@… to nimix
Status: newassigned

fixed in 2.5 branch and trunk

comment:7 by nimix, 16 years ago

Resolution: fixed
Status: assignedclosed

comment:8 by mschulz, 16 years ago

Resolution: fixed
Status: closedreopened
Version: 2.5 rc22.5 rc5

there still seems to be a problem left: when enabling a complete wms with the switchwms-checkbox, the query checkboxes of the layers are checked, but the layers are not added to querylayers: click with FI-tool on the map raises a JS-popup "Please select a layer!".

comment:9 by christoph, 16 years ago

Priority: majorblocker

comment:10 by christoph, 16 years ago

Resolution: fixed
Status: reopenedclosed

comment:11 by christoph, 16 years ago

Resolution: fixed
Status: closedreopened

now layers that are non queryable are added to the request....

comment:12 by christoph, 16 years ago

Owner: changed from nimix to christoph
Status: reopenednew

comment:13 by christoph, 16 years ago

Milestone: 2.5 release3.0 release
Owner: changed from christoph to nimix
Priority: blockermajor

this code is really bad.

we definitely need to replace this module by another one

comment:14 by nimix, 16 years ago

Resolution: fixed
Status: newclosed

comment:15 by mschulz, 16 years ago

Thx, Nimix. Tests with these changes were successfull.

comment:16 by christoph, 15 years ago

Milestone: 3.0 release2.5 release
Note: See TracTickets for help on using tickets.