Ticket #219 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

enabling FI from TreeGDE does not work

Reported by: rwoita Owned by: nimix
Priority: major Milestone: 2.5 release
Component: treeGDE Version: 2.5 rc5
Keywords: Cc: nimix

Description

look up following discussion on nabble.com :

http://www.nabble.com/MB-2.5-RC2---treeGDE-featureinfo1---2nd-to16874453.html

Change History

Changed 4 years ago by mschulz

  • version set to 2.5 rc2

setting the version to 2.5rc2

Changed 4 years ago by mschulz

  • cc nimix added
  • component changed from user interface to treeGDE

Just going through the code (realizing there have been profound changes ;-)) i found, that when changing only the querylayer status of a layer, mb_restateLayers is not called, thus the querylayers array is not updated. Adding a call the handleSelection as when changing visibility does the trick, but i'm not sure if this is correct or the intended usage of this function.

btw. also changed the component to treeGDE

Changed 4 years ago by christoph

apparently a function handleLayer of the WMS object is called...however, this function does nothing. The obscure code makes it impossible to debug.

Changed 4 years ago by nimix

I did some investigation today and the problem seems to be that the call of mb_restateLayers is missing. If you change the FI-Checkboxes and change the visibility of a layer afterwards the FI-Selection works

Changed 4 years ago by nimix

unfortunately I don't have my test evironement now, but as far as I can see the treefolder2.php from nimix_dev branch does it the right way.

Changed 4 years ago by nimix

  • owner changed from mapbender_dev@… to nimix
  • status changed from new to assigned

fixed in 2.5 branch and trunk

Changed 4 years ago by nimix

  • status changed from assigned to closed
  • resolution set to fixed

Changed 4 years ago by mschulz

  • status changed from closed to reopened
  • version changed from 2.5 rc2 to 2.5 rc5
  • resolution fixed deleted

there still seems to be a problem left: when enabling a complete wms with the switchwms-checkbox, the query checkboxes of the layers are checked, but the layers are not added to querylayers: click with FI-tool on the map raises a JS-popup "Please select a layer!".

Changed 4 years ago by christoph

  • priority changed from major to blocker

Changed 3 years ago by christoph

  • status changed from reopened to closed
  • resolution set to fixed

Changed 3 years ago by christoph

  • status changed from closed to reopened
  • resolution fixed deleted

now layers that are non queryable are added to the request....

Changed 3 years ago by christoph

  • owner changed from nimix to christoph
  • status changed from reopened to new

Changed 3 years ago by christoph

  • owner changed from christoph to nimix
  • priority changed from blocker to major
  • milestone changed from 2.5 release to 3.0 release

this code is really bad.

we definitely need to replace this module by another one

Changed 3 years ago by nimix

  • status changed from new to closed
  • resolution set to fixed

Changed 3 years ago by mschulz

Thx, Nimix. Tests with these changes were successfull.

Changed 3 years ago by christoph

  • milestone changed from 3.0 release to 2.5 release
Note: See TracTickets for help on using tickets.