Opened 3 years ago

Closed 3 years ago

#3181 closed defect (fixed)

i.segment watershed method available but not implemented

Reported by: madi Owned by: grass-dev@…
Priority: normal Milestone: 7.2.0
Component: Imagery Version: unspecified
Keywords: i.segment Cc:
CPU: Unspecified Platform: Unspecified

Description

In i.segment the default method is region growing, but there are also other options presented to the user: mean shift and watershed. However, the option method=watershed is not yet implemented. The user has the possibility to choose it from the GUI, and after the module loads input bands, which can take some time, it yields:

ERROR: Watershed is not yet implemented

This is inconvenient and I think it would be better to remove the watershed option from the menu until it is actually implemented.

Thanks

Change History (5)

comment:1 Changed 3 years ago by martinl

In 69692:

i.segment: watershed method disabled, see #3181

comment:2 Changed 3 years ago by martinl

In 69693:

i.segment: watershed and mean shift methods disabled, see #3181

comment:3 Changed 3 years ago by martinl

Milestone: 7.0.67.2.0

i.segment in G70 has only

      method   Segmentation method
               options: region_growing
               default: region_growing

I disabled watershed method in trunk (r69692) and also mean shift in G72 (r69693). Question: should be r69255 backported to relbr72 before 7.2.0RC1?

comment:4 in reply to:  3 ; Changed 3 years ago by mlennert

Replying to martinl:

i.segment in G70 has only

      method   Segmentation method
               options: region_growing
               default: region_growing

I disabled watershed method in trunk (r69692) and also mean shift in G72 (r69693). Question: should be r69255 backported to relbr72 before 7.2.0RC1?

-1

AFAIR, MarkusM and I decided deliberately to not backport to the release branch. The inclusion of mean shift and watershed into core i.segment in 7.2 happened "by accident" as it was done just 3 days before MarkusN created the 72 release branch, just when MarkusM was refactoring the code to prepare the GSoC project. See mainly r68468. This latter change can stay in 7.2 IMHO, but we shouldn't backport the rest as this stage. I will be for 7.4.

comment:5 in reply to:  4 Changed 3 years ago by martinl

Resolution: fixed
Status: newclosed

Replying to mlennert:

AFAIR, MarkusM and I decided deliberately to not backport to the release branch. The inclusion of mean shift and watershed into core i.segment in 7.2 happened "by accident" as it was done just 3 days before MarkusN created the 72 release branch, just when MarkusM was refactoring the code to prepare the GSoC project. See mainly r68468. This latter change can stay in 7.2 IMHO, but we shouldn't backport the rest as this stage. I will be for 7.4.

OK, thanks for explanation. I my eyes, we can close this ticket. Feel free to reopen if needed.

Note: See TracTickets for help on using tickets.