Opened 8 years ago

Last modified 5 years ago

#3169 new enhancement

use external shapelib

Reported by: opoplawski Owned by: grass-dev@…
Priority: normal Milestone: 7.6.2
Component: Database Version: svn-releasebranch72
Keywords: shapelib, OGR Cc:
CPU: Unspecified Platform: Unspecified

Description

Is there any reason at this point to not compile against an external shapelib?

Change History (10)

comment:1 by opoplawski, 8 years ago

See also issue #1318

in reply to:  description ; comment:2 by neteler, 8 years ago

Component: DefaultLibVector
Keywords: shapelib OGR added
Milestone: 7.0.57.2.1
Version: 7.0.4svn-releasebranch72

Replying to opoplawski:

Is there any reason at this point to not compile against an external shapelib?

AFAIR we picked shapelib many years ago from http://shapelib.maptools.org/ (points to http://download.osgeo.org/shapelib/). The last release appears to be from 2012 since it then became part of OGR (https://trac.osgeo.org/gdal/browser/branches/2.1/gdal/ogr/ogrsf_frmts/shape).

Here is what we changed after that (for some years we kept it in sync with OGR, then lost track due to the needed effort). For the procedure, see https://trac.osgeo.org/grass/browser/grass/trunk/lib/external/shapelib/README

The real question is: cannot we call the shape driver via OGR interface and drop our own copy?

in reply to:  2 comment:3 by mmetz, 8 years ago

Component: LibVectorDatabase

Replying to neteler:

Replying to opoplawski:

Is there any reason at this point to not compile against an external shapelib?

AFAIR we picked shapelib many years ago from http://shapelib.maptools.org/ (points to http://download.osgeo.org/shapelib/). The last release appears to be from 2012 since it then became part of OGR (https://trac.osgeo.org/gdal/browser/branches/2.1/gdal/ogr/ogrsf_frmts/shape).

Here is what we changed after that (for some years we kept it in sync with OGR, then lost track due to the needed effort). For the procedure, see https://trac.osgeo.org/grass/browser/grass/trunk/lib/external/shapelib/README

The real question is: cannot we call the shape driver via OGR interface and drop our own copy?

GRASS needs lib/external/shapelib to read and write dbf files. We can not use the OGR interface easily without rewriting db/drivers/dbf because shapefil.h is not installed with OGR. Also, GRASS does not need the full shapelib, only those parts relevant for dbf RW. An external shapelib is usually not installed because shapefiles can be accessed with the generic OGR interface.

comment:4 by martinl, 7 years ago

Milestone: 7.2.17.2.2

comment:5 by martinl, 7 years ago

Milestone: 7.2.27.4.0

All enhancement tickets should be assigned to 7.4 milestone.

comment:6 by neteler, 6 years ago

Milestone: 7.4.07.4.1

Ticket retargeted after milestone closed

comment:7 by neteler, 6 years ago

Milestone: 7.4.17.4.2

comment:8 by martinl, 6 years ago

Milestone: 7.4.27.6.0

All enhancement tickets should be assigned to 7.6 milestone.

comment:9 by martinl, 5 years ago

Milestone: 7.6.07.6.1

Ticket retargeted after milestone closed

comment:10 by martinl, 5 years ago

Milestone: 7.6.17.6.2

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.