i.segment.hierarchical install error

[dnewcomb]

When attempting to install the addon i.segment.hierarchical , I get the following error:

g.extension extension=i.segment.hierarchical svnurl=​http://svn.osgeo.org/grass/grass-addons/grass7 Fetching <i.segment.hierarchical> from GRASS-Addons SVN repository (be patient)... Compiling... Makefile:17: warning: overriding commands for target `/tmp/t mpvNhswj/i.segment.hierarchical/etc/i.segment.hierarchical' /usr/local/grass-7.0.0svn/include/Make/ScriptRules.make:19: warning: ignoring old commands for target `/tmp/tmpvNhswj/i. segment.hierarchical/etc/i.segment.hierarchical' Traceback (most recent call last):

File "/tmp/tmpvNhswj/i.segment.hierarchical/scripts/i.segm

ent.hierarchical", line 158, in <module>

from isegpatch import rpatch_map

ImportError: No module named isegpatch make: * [i.segment.hierarchical.tmp.html] Error 1 ERROR: Compilation failed, sorry. Please check above error messages.

[mlennert]

see also #2480, seems to be the same issue.

Moritz

[dnewcomb]

Replying to mlennert:

see also #2480, seems to be the same issue.

Moritz

Interesting, i.segment.gsoc installed without a problem.

[mlennert]

Replying to dnewcomb:

Replying to mlennert:

see also #2480, seems to be the same issue.

Moritz

Interesting, i.segment.gsoc installed without a problem.

That's a C-Module so different make logic. (And AFAIK it's actually superseded by i.segment in core).

Moritz

[martinl]

Tested with 7.0.5svn, i.segment.hierarchical installation works. I am taking liberty to close the ticket, feel free to reopen if needed.

[mlennert]

Replying to martinl:

Tested with 7.0.5svn, i.segment.hierarchical installation works. I am taking liberty to close the ticket, feel free to reopen if needed.

Reopening, since I can reproduce the error in trunk, but I think I found the reason:

g.extension i.segment.hierarchical
g.extension i.segment.hierarchical op=remove -f
g.extension i.segment.hierarchical

The first installation works, although I get the following warning:

Makefile:17: warning: overriding recipe for target '/tmp/grass7-mlennert-30404/tmpeM5UTQ/i.segment.hierarchical/etc/i.segment.hierarchical'
/home/mlennert/SRC/GRASS/grass_trunk/dist.x86_64-pc-linux-gnu/include/Make/ScriptRules.make:19: warning: ignoring old recipe for target '/tmp/grass7-mlennert-30404/tmpeM5UTQ/i.segment.hierarchical/etc/i.segment.hierarchical'
Installing...
Makefile:17: warning: overriding recipe for target '/tmp/grass7-mlennert-30404/tmpeM5UTQ/i.segment.hierarchical/etc/i.segment.hierarchical'
/home/mlennert/SRC/GRASS/grass_trunk/dist.x86_64-pc-linux-gnu/include/Make/ScriptRules.make:19: warning: ignoring old recipe for target '/tmp/grass7-mlennert-30404/tmpeM5UTQ/i.segment.hierarchical/etc/i.segment.hierarchical'
Updating addons metadata file...

However, the second installation attempt gives me the same error message as originally reported:

> g.extension i.segment.hierarchical
Fetching <i.segment.hierarchical> from GRASS GIS Addons repository (be
patient)...
Compiling...
Makefile:17: warning: overriding recipe for target '/tmp/grass7-mlennert-30404/tmpQxRkKD/i.segment.hierarchical/etc/i.segment.hierarchical'
/home/mlennert/SRC/GRASS/grass_trunk/dist.x86_64-pc-linux-gnu/include/Make/ScriptRules.make:19: warning: ignoring old recipe for target '/tmp/grass7-mlennert-30404/tmpQxRkKD/i.segment.hierarchical/etc/i.segment.hierarchical'
Traceback (most recent call last):
  File "/tmp/grass7-mlennert-30404/tmpQxRkKD/i.segment.hierarchical/scripts/i.segment.hierarchical", line 154, in <module>
    from isegpatch import rpatch_map
ImportError: No module named isegpatch
make: *** [i.segment.hierarchical.tmp.html] Error 1
ERROR: Compilation failed, sorry. Please check above error messages.

The issue seems to be an emtpy ~/.grass7/addons/etc/i.segment.hierarchical directory. When I erase that directory, installation works again (with the above warnings).

[mlennert]

When I install i.segment.hierarchical using the url parameter, I get the following warning:

> g.extension i.segment.hierarchical url=SRC/GRASS/grass-addons/grass7/imagery/i.segment.hierarchical/
Fetching <i.segment.hierarchical> from
</home/mlennert/SRC/GRASS/grass-addons/grass7/imagery/i.segment.hierarchical>
(be patient)...
Compiling...
Makefile:17: warning: overriding recipe for target '/tmp/grass7-mlennert-27332/tmpGjZYI8/i.segment.hierarchical/etc/i.segment.hierarchical'
/home/mlennert/SRC/GRASS/grass_trunk/dist.x86_64-pc-linux-gnu/include/Make/ScriptRules.make:19: warning: ignoring old recipe for target '/tmp/grass7-mlennert-27332/tmpGjZYI8/i.segment.hierarchical/etc/i.segment.hierarchical'
Installing...
Makefile:17: warning: overriding recipe for target '/tmp/grass7-mlennert-27332/tmpGjZYI8/i.segment.hierarchical/etc/i.segment.hierarchical'
/home/mlennert/SRC/GRASS/grass_trunk/dist.x86_64-pc-linux-gnu/include/Make/ScriptRules.make:19: warning: ignoring old recipe for target '/tmp/grass7-mlennert-27332/tmpGjZYI8/i.segment.hierarchical/etc/i.segment.hierarchical'
Installation of <i.segment.hierarchical> successfully finished

It seems to me (but I'm no expert on Makefiles) that the Makefile is overly complicated. Could someone check on that ?

[neteler]

Maybe follow the style of

grass-addons/grass7/imagery/i.fusion.hpf/Makefile

which also comes with extra .py files but a very simple Makefile

[martinl]

Remove Milestone from Addons bugreports.