Opened 16 years ago
Last modified 5 years ago
#250 new enhancement
ps.map: connected lines for region instruction box
| Reported by: | alf | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 7.6.2 |
| Component: | Ps.map | Version: | svn-trunk |
| Keywords: | line cap style vector round | Cc: | afrigeri@…, thare@… |
| CPU: | All | Platform: | All |
Description
Hello,
The code patch attached adds the 'cap' parameter to the vlines section of ps.map, allowing to control the look of the ends of a vector line, or the ends of the dashes in the case of a dashed line.
Three are the possible values: 'butt' (the default), 'round' for rounded ends and 'extbutt' for extended butt ends. More detals are reported in the updated documentation herein.
Please review it, test it and apply, if possible.
Regards,
Alessandro Frigeri
Attachments (1)
Change History (16)
by , 16 years ago
| Attachment: | psmap_linecap.diff added |
|---|
comment:1 by , 16 years ago
Hi,
patch looks good.
minor typo in docs: hald -> half line width. Please break HTML at column 75-80.
maybe initialize linecap to -1 instead of testing to see if it is NULL. (??)
before applying I'd like to hear ideas from the list on the added control vs. lost simplicity aspects. also, any ideas on how best to implement pattern=dashed and dotted? ("solid" is already there as an alias)
Hamish
comment:2 by , 16 years ago
screenshot examples of line-end types:
http://local.wasp.uwa.edu.au/~pbourke/dataformats/postscript/
Hamish
comment:3 by , 16 years ago
| Cc: | added |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:4 by , 16 years ago
| CPU: | x86-32 → All |
|---|
I had a look to do a similar thing with the region instruction, which is currently drawn as a series of individually stroked lines which do not connect and look ugly if line width is set thick. These lines are plotted using the do_plt.c plotting instruction tmp file. It can't be passed as a rectangle plot instruction as it subdivides the horizontal line into three sections in case the region goes the long way around a LL world.
I expect the easiest solution for the (sub)region box will be to put PS writing code directly into r_wind.c, but I worry that that code is executed before the main ps.map box is calculated and rendered.
So as a second solution for that- perhaps we should add a "Y" polyline instruction to the do_plt.c set of internal drawing commands. ??
As for the main wish, I am still waiting on any feedback wrt the level of control we should provide before applying the patch.
Hamish
comment:5 by , 16 years ago
| Summary: | ps.map: new parameter to set line cap style of vector lines → ps.map: connected lines for region instruction box |
|---|
comment:6 by , 15 years ago
| Cc: | removed |
|---|---|
| Owner: | changed from to |
| Status: | assigned → new |
reassigning the region box problem back to the dev-pool.
Hamish
comment:7 by , 12 years ago
| Milestone: | 6.4.0 → 7.0.0 |
|---|---|
| Priority: | major → normal |
| Version: | svn-develbranch6 → svn-trunk |
Since patches were only applied to trunk, updating milestone.
comment:8 by , 8 years ago
| Milestone: | 7.0.0 → 7.0.5 |
|---|
comment:9 by , 8 years ago
| Milestone: | 7.0.5 → 7.3.0 |
|---|
comment:12 by , 6 years ago
| Milestone: | 7.4.1 → 7.4.2 |
|---|
comment:13 by , 6 years ago
| Milestone: | 7.4.2 → 7.6.0 |
|---|
All enhancement tickets should be assigned to 7.6 milestone.
ps.map patch for line cap style - includes also documentation updates