run model menu item does not seem to work

[cmbarton]

I made and saved a model using the graphical modeler. The model works fine. I can load the saved model into the graphical modeler and it works fine.

If I select "run model" from the file menu and select this saved model, nothing happens. No error and nothing produced.

[martinl]

There is an error (check 'command output' if you have no debug level defined).

  File "/usr/local/src/grass64_release/dist.i686-pc-linux-gnu/etc/wxpython/gui_modules/gmodeler.py", line 1751, in _setPen
    pen = self.GetPen()
  File "/usr/lib/python2.6/dist-packages/wx-2.8-gtk2-unicode/wx/lib/ogl/_basic.py", line 2069, in GetPen
    return self._pen
AttributeError: 'ModelAction' object has no attribute '_pen'

Hopefully fixed in r48307 (trunk) and r48308 (devbr6). After some testing it could be backported to relbr64.

[cmbarton]

Tested in trunk. Now it runs without an error. But it does not respect the 'parameterization' checkbox when run this way. That is, it does not open a dialog for file selection or module options when the relevant parameterization box is checked. When loaded and run in the modeler GUI window, it does present dialogs for parameterized options. I don't know if this is by design or not.

Michael

[martinl]

Replying to cmbarton:

Tested in trunk. Now it runs without an error. But it does not respect the 'parameterization' checkbox when run this way. That is, it does not open a dialog for file selection or module options when the relevant parameterization box is checked. When loaded and run in the modeler GUI window, it does present dialogs for parameterized options. I don't know if this is by design or not.

hopefully fixed in r48342 (trunk) and r48343 (develbr6).

[martinl]

Replying to martinl:

Candidates for backport (relbr64):

• r48308
• r48343

[cmbarton]

I just tested. Parameterization is now respected in the run model. AFAICT it works fine. Thanks much!

Michael

[martinl]

Replying to cmbarton:

I just tested. Parameterization is now respected in the run model. AFAICT it works fine. Thanks much!

Backported to relr64 in r48387. Before closing this ticket, could you test also G64? Thanks.

[cmbarton]

Tested and it seems to work fine. I ran into an error initially that I traced to the fact that the output argument for r.blend has changed in GRASS 7 from "output" to "output_prefix" . A more accurate name for the argument but it breaks backward compatibility (permitted across version changes of course).

Thanks again for making this very nice tool for GRASS. I've already been recommending it as a way to get started writing Python scripts. I'll go ahead and close this.

BTW, how does the variables section work for the modeler?

Michael

[martinl]

Replying to cmbarton:

BTW, how does the variables section work for the modeler?

 http://www.youtube.com/watch?v=RztxMXXtA0s&feature=player_embedded#!

[cmbarton]

Very cool!

Thanks.

Michael