wxGUI Preferences: apply or save settings erases Layer Manager menu

[mmetz]

In the wxGUI Preferences dialog, when clicking on Apply or on Save, the menu bar "File Settings Raster .." is erased to blank. Cancel works.

Maybe related: in gui/wxpython/gui_modules/preferences.py, the function _updateSettings of class PreferencesDialog is never called, and the current window layout never saved. The function _updateSettings of class PreferencesBaseDialog does not check the current window layout.

[martinl]

Unable to reproduce this bug? What version of wxPython? Could you send a screenshot?

[wenzeslaus]

I also cannot reproduce it (grass 7, Ubuntu 10.04, wxPython 2.8.10.1 (gtk2-unicode)). But I think that problem is caused by new code writen by me (change menu style). Menu bar is re-created always after "Apply" or "Save".

The possible solution is do not change menu style (do not re-create menu) on the fly but only after GUI restart (same as "icon theme").

[martinl]

Replying to wenzeslaus:

I also cannot reproduce it (grass 7, Ubuntu 10.04, wxPython 2.8.10.1 (gtk2-unicode)). But I think that problem is caused by new code writen by me (change menu style). Menu bar is re-created always after "Apply" or "Save".

it can be, see r46397

[mmetz]

screenshot of erased menubar

[mmetz]

I have a screenshot attached. My wxPython version is 2.8.12, recently upgraded from 2.8.11, and I can not remember having seen this before. Maybe this is the problem, because wxPython often comes with interesting changes between 2.8.x versions. Or my Fedora version of wxPython is patched to death...

Downgrading priority.

[martinl]

Replying to martinl:

Replying to wenzeslaus:

I also cannot reproduce it (grass 7, Ubuntu 10.04, wxPython 2.8.10.1 (gtk2-unicode)). But I think that problem is caused by new code writen by me (change menu style). Menu bar is re-created always after "Apply" or "Save".

it can be, see r46397

patch provided by Vaclav applied in r46665 (& backported to devbr6/relbr64).