Changes between Version 13 and Version 14 of RFC4

Timestamp:

Mar 26, 2017, 11:56:04 AM (7 years ago)

Author:

mloskot

Comment:

Add GCC6 warnings

RFC4

@@ -142 +142 @@
 Set up Travis CI "style safety valve" build dedicated to run clang-format lint based on the approach used in `​clang_format.py` script by MongoDB.
 
+== Miscellaneous ==
+
+Those who build GEOS with GCC 6+ may appreciate consistent code format style as it will help to avoid some of the [https://developers.redhat.com/blog/2016/02/26/gcc-6-wmisleading-indentation-vs-goto-fail/ new compiler warnings]:
+
+{{{
+src/geom/Polygon.cpp: In member function ‘virtual int geos::geom::Polygon::getCoordinateDimension() const’:
+src/geom/Polygon.cpp:154:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
+     if( shell != NULL )
+     ^~
+src/geom/Polygon.cpp:157:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
+  size_t nholes=holes->size();
+  ^~~~~~
+}}}
+
 == References ==