Compiler warnings in densifier

[dbaston]

/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp: In constructor ‘geos::geom::util::Densifier::DensifyTransformer::DensifyTransformer(double)’:
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:51:75: warning: declaration of ‘distanceTolerance’ shadows a member of ‘geos::geom::util::Densifier::DensifyTransformer’ [-Wshadow]
 Densifier::DensifyTransformer::DensifyTransformer(double distanceTolerance):
                                                                           ^
In file included from /home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:21:0:
/home/dbaston/dev/libgeos/include/geos/geom/util/Densifier.h:74:10: note: shadowed declaration is here
   double distanceTolerance;
          ^
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp: In member function ‘virtual geos::geom::Geometry::Ptr geos::geom::util::Densifier::DensifyTransformer::transformPolygon(const geos::geom::Polygon*, const geos::geom::Geometry*)’:
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:76:26: warning: unused variable ‘mp’ [-Wunused-variable]
  if (const MultiPolygon* mp=dynamic_cast<const MultiPolygon*>(parent) )
                          ^
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp: In static member function ‘static std::unique_ptr<std::vector<geos::geom::Coordinate> > geos::geom::util::Densifier::densifyPoints(geos::geom::Coordinate::Vect, double, const geos::geom::PrecisionModel*)’:
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:110:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  for (int i = 0; i < pts.size()-1; i++)
                    ^
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:109:33: warning: variable ‘it’ set but not used [-Wunused-but-set-variable]
  geom::CoordinateList::iterator it = coordList.begin();
                                 ^
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp: In member function ‘geos::geom::Geometry::Ptr geos::geom::util::Densifier::densify(const geos::geom::Geometry*, double)’:
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:143:66: warning: declaration of ‘distanceTolerance’ shadows a member of ‘geos::geom::util::Densifier’ [-Wshadow]
 Densifier::densify(const Geometry *geom, double distanceTolerance)
                                                                  ^
In file included from /home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:21:0:
/home/dbaston/dev/libgeos/include/geos/geom/util/Densifier.h:67:9: note: shadowed declaration is here
  double distanceTolerance;
         ^
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp: In constructor ‘geos::geom::util::Densifier::DensifyTransformer::DensifyTransformer(double)’:
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:51:75: warning: declaration of ‘distanceTolerance’ shadows a member of ‘geos::geom::util::Densifier::DensifyTransformer’ [-Wshadow]
 Densifier::DensifyTransformer::DensifyTransformer(double distanceTolerance):
                                                                           ^
In file included from /home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:21:0:
/home/dbaston/dev/libgeos/include/geos/geom/util/Densifier.h:74:10: note: shadowed declaration is here
   double distanceTolerance;
          ^
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp: In member function ‘virtual geos::geom::Geometry::Ptr geos::geom::util::Densifier::DensifyTransformer::transformPolygon(const geos::geom::Polygon*, const geos::geom::Geometry*)’:
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:76:26: warning: unused variable ‘mp’ [-Wunused-variable]
  if (const MultiPolygon* mp=dynamic_cast<const MultiPolygon*>(parent) )
                          ^
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp: In static member function ‘static std::unique_ptr<std::vector<geos::geom::Coordinate> > geos::geom::util::Densifier::densifyPoints(geos::geom::Coordinate::Vect, double, const geos::geom::PrecisionModel*)’:
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:110:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  for (int i = 0; i < pts.size()-1; i++)
                    ^
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:109:33: warning: variable ‘it’ set but not used [-Wunused-but-set-variable]
  geom::CoordinateList::iterator it = coordList.begin();
                                 ^
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp: In member function ‘geos::geom::Geometry::Ptr geos::geom::util::Densifier::densify(const geos::geom::Geometry*, double)’:
/home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:143:66: warning: declaration of ‘distanceTolerance’ shadows a member of ‘geos::geom::util::Densifier’ [-Wshadow]
 Densifier::densify(const Geometry *geom, double distanceTolerance)
                                                                  ^
In file included from /home/dbaston/dev/libgeos/src/geom/util/Densifier.cpp:21:0:
/home/dbaston/dev/libgeos/include/geos/geom/util/Densifier.h:67:9: note: shadowed declaration is here
  double distanceTolerance;
         ^

[pramsey]

Not seeing this now, yay.