Opened 6 years ago

Closed 6 years ago

#856 closed defect (fixed)

FALLTHRUGH warning gcc-7

Reported by: cvvergara Owned by: strk
Priority: trivial Milestone: 3.7.0
Component: Core Version: 3.6.2
Severity: Annoyance Keywords:
Cc:

Description

There is a: https://travis-ci.org/OSGeo/geos/jobs/331384379#L4304

FALLTHRUGH warning on g++11 when using gcc-7

home/travis/build/OSGeo/geos/tests/xmltester/tinyxml/tinyxmlparser.cpp:113:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
    input >>= 6;
    ~~~~~~^~~~~
/home/travis/build/OSGeo/geos/tests/xmltester/tinyxml/tinyxmlparser.cpp:114:3: note: here
   case 3:
   ^~~~
/home/travis/build/OSGeo/geos/tests/xmltester/tinyxml/tinyxmlparser.cpp:117:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
    input >>= 6;
    ~~~~~~^~~~~
/home/travis/build/OSGeo/geos/tests/xmltester/tinyxml/tinyxmlparser.cpp:118:3: note: here
   case 2:
   ^~~~
/home/travis/build/OSGeo/geos/tests/xmltester/tinyxml/tinyxmlparser.cpp:121:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
    input >>= 6;
    ~~~~~~^~~~~
/home/travis/build/OSGeo/geos/tests/xmltester/tinyxml/tinyxmlparser.cpp:122:3: note: here

Change History (4)

comment:1 by strk, 6 years ago

tinyxml is an external piece of code, I'd actually like to drop it and rely on system installed version (version 2 is packaged these days).

There is a tinyxml2 branch in git which was aimed at this, do you feel like bringing it up to date ?

comment:2 by robe, 6 years ago

Milestone: 3.7.03.8.0

move this back if you plan to get to it before 3.7.0 release.

I suppose since it's just a testing tool it can go in beta or even rc.

comment:4 by cvvergara, 6 years ago

Milestone: 3.8.03.7.0
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.