Opened 7 years ago

Closed 5 years ago

#838 closed patch (fixed)

Invalid union of valid geometres [JTS fails too]

Reported by: strk Owned by: strk
Priority: major Milestone: 3.6.4
Component: Core Version: 3.6.2
Severity: Unassigned Keywords:
Cc: mbdavis

Description

The attached XML testcase shows an invalid return from valid inputs. You can test using: 

XMLTester --test-valid-input --test-valid-output test.xml

Possibly related tickets: #789, #523

Attachments (1)

bug838.xml​ (2.2 KB ) - added by strk 7 years ago.

Download all attachments as: .zip

Change History (10)

by strk, 7 years ago

Attachment: bug838.xml​ added

comment:1 by strk, 7 years ago

Summary: Invalid union of valid geometres → Invalid union of valid geometres [JTS fails too]

JTS fails too as of this commit: ​https://github.com/locationtech/jts/commit/8e6abedeca3f3c1905c2f58c0a2dccc77f1f2f12

It outputs this result (in HEXWKB form, to make sure invalidity is not introduced by the WKT output): 

0000000003000000010000001E412CD36E9999999A413D8FCD33333333412CD436CCCCCCCD413D8FCE1999999A412CD43866666667413D8F6A00000000412CD5C8CCCCCCCD413D8F6BB3333333412CD5CA9999999A413D8F079999999A412CD75B00000000413D8F0966666667412CD75933333333413D8F6D80000000412CD82166666667413D8F6E4CCCCCCD412CD9B1CCCCCCCD413D8F701999999A412CDA552B6E6B69413D8F70C0B930DF412CDA739810624E413D8F46FEF9DB23412CDA69D810624E413D8F37EFDF3B65412CD9D4D50CE8F7413D8EA7FBC39C12412CD8ED33333333413D8EA700000000412CD8ED33333333413D8EA700000001412CD82500000001413D8EA61999999A412CD82333333334413D8F0A33333333412CD8EB66666666413D8F0B19999999412CD8ED2B33935A413D8EA8BCCEAAFB412CD8EB66666667413D8F0B1999999A412CD82333333334413D8F0A33333333412CD82500000000413D8EA61999999A412CD6949999999A413D8EA466666667412CD69800000000413D8DDC33333333412CD5079999999A413D8DDA80000000412CD50266666667413D8F06CCCCCCCD412CD43A33333333413D8F05E6666667412CD43C00000000413D8EA1CCCCCCCD412CD373CCCCCCCD413D8EA0E6666667412CD36E9999999A413D8FCD33333333

Issue filed upstream: ​https://github.com/locationtech/jts/issues/107

comment:2 by strk, 6 years ago

Cc: mbdavis added

A possible improvement in the validator was suggested by Dr.JTS here: ​https://github.com/locationtech/jts/issues/107#issuecomment-329975263

comment:3 by Sandro Santilli <strk@…>, 6 years ago

Resolution: → fixed
Status: assigned → closed

In 6a805a5/git:

Port experimental overlay validation fix from JTS-1.15+

Closes #838
See ​https://github.com/locationtech/jts/issues/107#issuecomment-359321512

comment:4 by strk, 6 years ago

PR porting experimental fix by DrJTS is here: ​https://git.osgeo.org/gitea/geos/geos/pulls/22

comment:5 by strk, 6 years ago

Resolution: fixed
Status: closed → reopened

There's something wrong with the communication between GIT and Trac, in that this ticket was closed by a push to a "pull" git reference, not any official branch, so the ticket should have not been closed. I'll file an issue about this.

comment:6 by strk, 6 years ago

For the record, the git-hook issue was filed as #854 (and should be fixed arleady)

comment:7 by robe, 6 years ago

Milestone: 3.6.3 → 3.6.4
Type: defect → patch

comment:8 by Paul Ramsey <pramsey@…>, 5 years ago

In 609e764/git:

Invalid union result from valid polygon inputs
References #838

comment:9 by Paul Ramsey <pramsey@…>, 5 years ago

Resolution: → fixed
Status: reopened → closed

In 287b45d/git:

Invalid union result from valid polygon inputs
Closes #838

Note: See TracTickets for help on using tickets.