| 18 | | # Configure [https://help.github.com/articles/configuring-protected-branches/ Protected Branches] |
| 19 | | # [https://help.github.com/articles/about-pull-request-reviews/#required-reviews Disable Merge Button] until commit changes are approved by a peer |
| | 19 | Note, we do not [https://help.github.com/articles/about-pull-request-reviews/#required-reviews Disable Merge Button] until commit changes are approved by a peer, because that would block case when a particular developer wants to commit directly to upstream branch with prior CI-tested PR on GitHub - requesting others to review would be unnecessary. GitHub does not allow PRs self-reviewed by submitting contributor. |
| | 20 | |
| | 21 | Screenshot shows recommended settings for protected branches. |
| | 22 | |
| | 23 | List of protected branches: |
| | 24 | * `svn-trunk` |
| | 25 | * `svn-X.Y` |
