Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#611 closed defect (fixed)

[PATCH] Move static class members of Interrupt out of header

Reported by: mloskot Owned by: strk
Priority: major Milestone: 3.4.0
Component: Default Version: master
Severity: Significant Keywords:
Cc:

Description

In Interrupt class, static class members are accessed from several inline functions but they are not part of the exportable interface of GEOS DLL causing linker errors.

Simple solution is to move them out of the header.

Patch attached.

Attachments (1)

move-static-members-out-of-header.patch (2.9 KB) - added by mloskot 6 years ago.
Move static members of Interrupt class out of header

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by mloskot

Move static members of Interrupt class out of header

comment:1 Changed 6 years ago by strk

Milestone: 3.3.73.4.0

no problem here, can you just git svn-dcommit ?

comment:2 Changed 6 years ago by mloskot

I generated the patch from my copy of SVN trunk. I don't use the Git mirror. Is that a problem?

comment:3 Changed 6 years ago by strk

No problem, svn commit away ! Don't forget an entry in the NEWS file pointing here. Thanks

comment:4 Changed 6 years ago by strk

Owner: changed from geos-devel@… to strk
Status: newassigned

Forget the NEWS file (it's a new thing). I'm testing locally and I'll commit myself. Thanks !

comment:5 Changed 6 years ago by strk

Resolution: fixed
Status: assignedclosed

Committed with r3744

comment:6 Changed 6 years ago by mloskot

strk, thanks!

Note: See TracTickets for help on using tickets.