Opened 6 years ago

Closed 3 years ago

#577 closed enhancement (wontfix)

Makefile.vc lacks install / uninstall / test procedures

Reported by: RMWChaos Owned by: pramsey
Priority: minor Milestone: 3.5.0
Component: Build/Install Version: master
Severity: Annoyance Keywords: MSVC NMake Makefile patch
Cc: RMWChaos

Description

Makefile.vc (not using CMake) performs the build / compile, but lacks the code to perform "nmake /f makefile.vc install-all / uninstall / test". Also, does not account for customized installation (PREFIX) paths.

I have two files to attach that add install-all and uninstall code as well as implement custom install paths: geos/makefile.vc and geos/src/makefile.vc (both are required to implement the features as geos/makefile.vc delegates making targets to geos/src/makefile.vc

Need to know more about how the testing works to build that code.

Attachments (2)

makefile.vc (1.0 KB) - added by RMWChaos 6 years ago.
geos/makefile.vc
Makefile.vc (19.2 KB) - added by RMWChaos 6 years ago.
geos/src/makefile.vc

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by RMWChaos

Attachment: makefile.vc added

geos/makefile.vc

comment:1 Changed 6 years ago by RMWChaos

Type: defectenhancement
Version: 3.3.4svn-trunk

Updated Type and Version.

comment:2 Changed 6 years ago by RMWChaos

Updated geos/src/makefile.vc to rename geos_c_i.lib to geos_c.lib on install-all.

Changed 6 years ago by RMWChaos

Attachment: Makefile.vc added

geos/src/makefile.vc

comment:3 Changed 6 years ago by strk

Milestone: 3.3.53.4.0

comment:4 Changed 5 years ago by robe

Keywords: patch added

comment:5 Changed 5 years ago by robe

Cc: RMWChaos added

Would it be possible for you to give a real patch and if that's too hard just an updated file. Unfortunately trunk has changed so much since you posted this that I can't safely tell what should be changed.

comment:6 Changed 5 years ago by robe

Milestone: 3.4.03.5.0

no response - push

comment:7 Changed 3 years ago by robe

Resolution: wontfix
Status: newclosed

I don't think we should support VC without CMake and given lack of interest on this -- I'm just going to close this out as wontfix. If someone cares, feel free to reopen and mark for 3.6.0

Note: See TracTickets for help on using tickets.