Ticket #487 (closed enhancement: fixed)

Opened 3 years ago

Last modified 10 months ago

Port Delaunay Triangulation API from JTS

Reported by: strk Owned by: geos-devel@…
Priority: major Milestone: 3.4.0
Component: Default Version: svn-trunk
Severity: Unassigned Keywords: history
Cc: mateusz@…, blc56, woodbri

Description (last modified by strk) (diff)

Delaunay triangulation is a big new package in JTS 1.11 which wasn't ported out yet. It consists in 26 new classes + 3 testcases at the C++ level.

Attachments

delaunay.patch Download (103.8 KB) - added by blc56 23 months ago.
delaunayv1.patch Download (103.7 KB) - added by blc56 22 months ago.

Change History

Changed 3 years ago by strk

  • description modified (diff)

Changed 3 years ago by mloskot

  • cc mateusz@… added

Changed 23 months ago by blc56

Changed 23 months ago by blc56

I've attached a patch which implements enough of Delaunay Triangulation to get a functioning DelaunayTriangulationBuilder? class. It includes the DelaunayTest? testcase. The patch is also available in my libgeos fork on github:  https://github.com/blc56/libgeos

Comments and criticism are welcome. Thanks!

Ben

Changed 23 months ago by blc56

  • cc blc56 added

Changed 23 months ago by strk

A couple of things I noticed:

  1. You assigned the copyright to Refractions Research in 2006
  2. The "Last port" line should contain the SVN revision id of the JTS file you ported

didn't look at the actual code yet (will do as soon as I find a few hours)

Thanks for contributing, btw :)

Changed 23 months ago by woodbri

  • cc woodbri added

Changed 22 months ago by blc56

Thanks! I've attached an patch with updated copyright attributions and JTS svn revisions. I can change the copyright attribution as necessary to facilitate inclusion.

Changed 22 months ago by blc56

Changed 22 months ago by strk

Your patch is fully in as of r3693

Next stop: C API exposure

Changed 22 months ago by strk

Benjamin: very good job, I very much like the way you followed existing style and took care of memory leaks :)

Changed 22 months ago by strk

and const correctness too !

Changed 22 months ago by strk

  • status changed from new to closed
  • resolution set to fixed

Changed 22 months ago by strk

#565 is about the C-API exposure

Changed 22 months ago by strk

Benjamin: I noticed the triangulation does not retain the Z value. Is this the case in JTS as well ?

Changed 22 months ago by blc56

I'm not sure off the top of my head. I'll check on the JTS behavior. I'll be able to get to it before the end of next week.

Changed 22 months ago by strk

I created #570 for that, please followup there. Thanks!

Changed 10 months ago by robe

  • keywords history added
Note: See TracTickets for help on using tickets.