Opened 13 years ago

Closed 11 years ago

Last modified 6 years ago

#440 closed defect (wontfix)

xmltester failures under MingW 32 bit

Reported by: robe Owned by: geos-devel@…
Priority: major Milestone: GEOS Fund Me
Component: Default Version: main
Severity: Unassigned Keywords: mingw
Cc:

Description

strk,

Attached is the log file of my failures on geos 3.3.0 rc1 compilation of tar ball.

Attachments (2)

makecheckgeos_fails.log (8.3 KB ) - added by robe 13 years ago.
temp.log (32.9 KB ) - added by robe 13 years ago.

Download all attachments as: .zip

Change History (13)

by robe, 13 years ago

Attachment: makecheckgeos_fails.log added

comment:1 by strk, 13 years ago

Failure for #350 is indeed the originally reported faiure. This is annoying. Are you sure you're building with -ffloat-store ? Could you retry that with r3338 or r3335 ? Or generally bisect to see if you got any success for it ?

As per the #398 failure it does look like a minor coordinate drift. We're checking for exact equality (pointwise) which is the reason for the failure. Note that also JTS checks for pointwise equality, which is the reason why I've tried to track as closely as possible JTS as per operations precision, getting back from long doubles to single doubles...

comment:2 by robe, 13 years ago

nope not sure -- do I pass with --ffloat-store in the configure step?

comment:3 by strk, 13 years ago

It'll be automatic if you're using automake and your compiler supports it. Check with:

grep AM_CXXFLAGS Makefile

comment:4 by robe, 13 years ago

Looks like it does

AM_CXXFLAGS = -DGEOS_INLINE -pedantic -Wall -ansi -Wno-long-long -ffloat-store

comment:5 by robe, 13 years ago

With geos 3.3.0rc2 i still get 4 failures. I'll attach my new log in case it's different.

by robe, 13 years ago

Attachment: temp.log added

comment:6 by strk, 13 years ago

Could you also check:

grep CXXFLAGS Makefile

I want to make sure -O2 is used. Also, which compiler version ? Both failing tests are very sensible to numeric robustness issues...

comment:7 by robe, 13 years ago

strk output is:

AM_CXXFLAGS =  -DGEOS_INLINE  -pedantic -Wall -ansi -Wno-long-long  -ffloat-store
CXXFLAGS = -g -O2

comment:8 by robe, 13 years ago

Just for extra information:

I'm running: gcc version 3.4.5 (mingw-vista special r3

I'll try a newer one once I remember how I toggled back and forth between the 2 gccs before.

comment:9 by strk, 13 years ago

Milestone: 3.3.0GEOS Future

unless someone commits to fix this there's no point in targetting a real milestone.

comment:10 by robe, 11 years ago

Resolution: wontfix
Status: newclosed

3.4.5 is pretty much dead. I think this is moot and doesn't affect my mingw64-w32 chain.

comment:11 by robe, 6 years ago

Milestone: GEOS FutureGEOS Fund Me

Milestone renamed

Note: See TracTickets for help on using tickets.