Expose getX, getY, getPointN, getStartPoint, getEndPoint, isClosed, getLength and getNumPoints

[atrofast]

I've attached a patch that exposes these C++ class methods as CAPI functions:

LineString::getPointN -> GEOSGetPointN
LineString::getStartPoint -> GEOSGetStartPoint
LineString::getEndPoint -> GEOSGetEndPoint
LineString::isClosed -> GEOSisClosed
LineString::getLength -> GEOSGetLength
LineString::getNumPoints -> GEOSGetNumPoints
Point::getX -> GEOSGetX
Point::getY -> GEOSGetY

Additionally I wrote a small test case for the new functions.

[atrofast]

Exposes the methods listed

[mloskot]

Alex, thanks for the patch. The patch technically looks good to me.

However, I have removed the milestone as it is likely unspecified when it will be applied. I suppose Paul or Sandro will have to decide about it becasue it's not a trivial change. I do not maintain C API myself. Let's see.

[pramsey]

Is it possible you'll be adding other accessors? I've set the milestone to 3.3, since we promised not to change the API during minor revisions.

[mloskot]

Paul,

Sure, I can do technical steps: patch, test and commit. I just need you or Sandro to make decision what goes to C API and when.

[strk]

My 2c:

I see the new functions are called something like: GEOSGetPointN But they take a GEOSGeometry.

My concern is that since we already expose a GEOSCoordSequence, and in future could also expose a GEOSCoordinate, assigning those symbols to implicitly work on Geometry will represent a problem.

How about renaming them to be explicit about taking Geometry ? We're not in C++ land here, no overloads possible :)

[atrofast]

strk:

I don't think that's a problem, so should the new list be:

• GEOSGeomGetPointN
• GEOSGeomGetX
• GEOSGeomGetY
• GEOSGeomGetStartPoint
• GEOSGeomGetEndPoint
• GEOSGeomGetNumPoints
• GEOSisClosed (isSimple and isEmpty are defined as such)

Thanks for the feedback, very much appreciated!

[atrofast]

With updated names

[atrofast]

I've attached a new patch with the updated names, if you have any questions, please let me know. Thanks!

[warmerdam]

I have applied the second patch in trunk as there were no further issues raised (r2992).