#310 closed task (fixed)
Unify prototypes of WKTReader and WKBReader constructor
Reported by: | mloskot | Owned by: | strk |
---|---|---|---|
Priority: | major | Milestone: | 3.4.0 |
Component: | Core | Version: | main |
Severity: | Annoyance | Keywords: | history |
Cc: |
Description
Constructor of both WKTReader and WKBReader accept GeometryFactory, however both do it in different way:
- WKBReader accepts reference to const GeometryFactory object
- WKTReader accepts pointer
This is inconsistent and requires extra work on client side. For example, if one wants to write simple function or class template that can be specialised by any of the two reader types it becomes a challenge.
I would suggest to change ctor of WKTReader to accept reference instead of pointer.
Change History (8)
comment:1 by , 14 years ago
Milestone: | → 3.3.0 |
---|
comment:2 by , 13 years ago
Milestone: | 3.3.0 |
---|
comment:3 by , 13 years ago
Milestone: | → GEOS Future |
---|
comment:4 by , 11 years ago
Milestone: | GEOS Future → 3.4.0 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Type: | defect → task |
Done in r3770
comment:5 by , 11 years ago
Keywords: | history added |
---|
Note:
See TracTickets
for help on using tickets.
+1
Btw, wouldn't you call these "troubles" ? :)