Ticket #269 (closed enhancement: fixed)

Opened 3 years ago

Last modified 10 months ago

Silent warning on mixed class and struct keyword

Reported by: mloskot Owned by: mloskot
Priority: minor Milestone:
Component: C API Version: svn-trunk
Severity: Unassigned Keywords:
Cc:

Description

It's perfectly safe to silent these warning  C4099:

1>g:\dev\geos\_svn\trunk\capi\geos_c.h(738) : warning C4099: 'geos::io::WKTReader' : type name first seen using 'class' now seen using 'struct'
1>        g:\dev\geos\_svn\trunk\source\headers\geos\io\wktreader.h(59) : see declaration of 'geos::io::WKTReader'
1>g:\dev\geos\_svn\trunk\capi\geos_c.h(739) : warning C4099: 'geos::io::WKTWriter' : type name first seen using 'class' now seen using 'struct'
1>        g:\dev\geos\_svn\trunk\source\headers\geos\io\wktwriter.h(74) : see declaration of 'geos::io::WKTWriter'
1>g:\dev\geos\_svn\trunk\capi\geos_c.h(740) : warning C4099: 'geos::io::WKBReader' : type name first seen using 'class' now seen using 'struct'
1>        g:\dev\geos\_svn\trunk\source\headers\geos\io\wkbreader.h(73) : see declaration of 'geos::io::WKBReader'
1>g:\dev\geos\_svn\trunk\capi\geos_c.h(741) : warning C4099: 'geos::io::WKBWriter' : type name first seen using 'class' now seen using 'struct'
1>        g:\dev\geos\_svn\trunk\source\headers\geos\io\wkbwriter.h(73) : see declaration of 'geos::io::WKBWriter'

by putting the following pragma on top of translation units of C API:

#ifdef _MSC_VER
#pragma warning(disable : 4099)
#endif

For C++, there is no difference (in that case reported above) between struct and class keywords - C++ standard uses these keywords interchangeable.

Change History

Changed 3 years ago by pramsey

  • owner changed from pramsey to mloskot
  • milestone set to 3.1.1

Go for it, I have full trust! Please apply to 3.1 branch if appropriate and trunk.

Changed 2 years ago by pramsey

  • milestone changed from 3.1.1 to 3.1.2

Changed 2 years ago by mloskot

  • status changed from new to assigned

Changed 2 years ago by mloskot

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in trunk (r2717)

Changed 10 months ago by strk

  • milestone 3.1.2 deleted

Milestone 3.1.2 deleted

Note: See TracTickets for help on using tickets.