Ticket #268 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

nullCoord defunition mixes static and dllimport

Reported by: mloskot Owned by: mloskot
Priority: blocker Milestone: 3.2.0
Component: Core Version: svn-trunk
Severity: Unassigned Keywords: dllimport,static
Cc:

Description (last modified by mloskot) (diff)

Building of trunk r2600 using Visual C++ 8.0 fails with the following error: 

geom\Coordinate.cpp(31) : error C2491: 'geos::geom::Coordinate::nullCoord' : 
   definition of dllimport static data member not allowed

Attachments

fix-msvc-sync90-80.patch Download (21.5 KB) - added by sanak 3 years ago.
TortoiseSVN(Japanese)
fix-msvc-sync90-80_r2609.patch Download (19.9 KB) - added by sanak 3 years ago.
TortoiseSVN(Japanese)

Change History

  Changed 3 years ago by mloskot

  • description modified (diff)

Changed 3 years ago by sanak

TortoiseSVN(Japanese)

  Changed 3 years ago by sanak

I think that this problem is related to r2556.

I had make patch for msvc80 sync to msvc90.

Regards,

  Changed 3 years ago by pramsey

  • owner changed from geos-devel@… to mloskot

  Changed 3 years ago by pramsey

  • milestone set to 3.2.0

Changed 3 years ago by sanak

TortoiseSVN(Japanese)

  Changed 3 years ago by sanak

mloskot, strk,

I had updated previous patch.
Modified points are as follows.
- Add GEOS_DLL_EXPORT definition to geos_c_dll.vcproj.
- Synchronise geos_lib.vcproj and geos_unit.vcproj to msvc90 ones.
Please see #273 for details.

Regards,

follow-up: ↓ 7   Changed 3 years ago by mloskot

  • status changed from new to closed
  • resolution set to fixed

OK for me. Closing

p.s. sorry for delay - holidays

in reply to: ↑ 6   Changed 3 years ago by sanak

mloskot,

Sorry, my explanation was insufficiency. The msvc90 projects was fixed at #273, but the msvc80 projects need update for the latest trunk. (algorithm/distance/DiscreteHausdorffDistance.cpp .etc)

But the original issue of this ticket is "dllimport" problem, So should I create new ticket for msvc80 sync problem and attach fix-msvc-sync90-80_r2609.patch ?

Regards,

Note: See TracTickets for help on using tickets.