GEOS, Shapely, DLLs, and memory

[aronb]

Add a GEOSFree function to the capi so that users can free memory allocated in the GEOS DLL from the same DLL. This is needed if the user code is using a different copy of the CRT than GEOS.

•  Original post to geos-devel

•  Potential Errors Passing CRT Objects Across DLL Boundaries

[aronb]

GEOSFree patch

[mloskot]

A minor impr. to the patch - missing std qualifier:

void GEOSFree (void* buffer) 
{ 
   std::free(buffer); 
}

[warmerdam]

I have apply the change in trunk, and added a GEOSFree_r() (r2506). I don't understand the requirement for std:: qualifier and did not add it.

I would still like to backport this into the stable 3.2 and 3.0 branches but this will apparently require further discussion on the list.

[mloskot]

Frank,

The free() function is declared in <cstdlib> and this header should be included (and it is from geos_ts_c.cpp). The free() function (as all C++ free standard functions) is declared in std namespace. So, std::free() should be qualified with name of its namespace, for the same reasons why std::vector<int> but not vector<int>.

BTW, shouldn't GEOSFree delegate deallocation to GEOSFree_r?

[warmerdam]

Suggested changes made in trunk (r2507).

[warmerdam]

With the implicit permission on the list I have applied the changes in 3.1 branch as well (r2509).

I believe testing for a CAPI version of greater than 1.5.0 should be sufficient to know if GEOSFree() is available as part of the GEOS C API.