Ticket #199 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

std:log() use in BufferOp.cpp breaks build on MSVC 7.1

Reported by: warmerdam Owned by:
Priority: major Milestone: 3.1.0
Component: Core Version: svn-trunk
Severity: Critical Keywords: cmath math.h std
Cc: mloskot

Description

        cl -Iheaders /MD /GR /O2 /W3 /nologo /D "NDEBUG"  /D "NOMINMAX" /D "WIN32_LEAN_AND_MEAN" /D "NOGDI"  /GX /c operation\buffer\BufferOp.cpp /Fooperation\buffer\BufferOp.obj
BufferOp.cpp
operation\buffer\BufferOp.cpp(72) : error C2039: 'log' : is not a member of 'std'
operation\buffer\BufferOp.cpp(72) : error C2039: 'log' : is not a member of 'std'
operation\buffer\BufferOp.cpp(75) : error C2039: 'pow' : is not a member of 'std'
NMAKE : fatal error U1077: 'cl' : return code '0x2'
Stop.

Change History

Changed 3 years ago by warmerdam

  • cc mloskot added
  • status changed from new to closed
  • resolution set to fixed

I have "fixed" this by adding a cmath include in r2171, but I'm not sure if this is exactly right. I'm adding mloskot to cc: list since it appears he changed this code to use the std:: prefix.

Changed 3 years ago by mloskot

  • keywords cmath math.h std added
  • component changed from Build/Install to Core
  • severity changed from Unassigned to Critical
  • milestone set to 3.0.1

Frank,

Yes, you are right I did it. Probably, when I was adding std:: prefix, <cmath> was included indirectly by some other headers, so it compiled. I was just about to fix it. I confirm your patch works perfectly. Thank you for fixing!

Changed 3 years ago by anonymous

  • milestone 3.0.1 deleted

Milestone 3.0.1 deleted

Changed 3 years ago by pramsey

  • milestone set to 3.1.0
Note: See TracTickets for help on using tickets.