Ticket #184 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

Some parts of documented C++ API do not available for public usage

Reported by: dron Owned by: mloskot
Priority: major Milestone: 3.2.0
Component: Documentation Version: 3.0.0
Severity: Unassigned Keywords:
Cc: mloskot

Description

There are number of header files not being installed system wide hence are not available to user but still being documented. E.g., there are many files under the headers/geos/algorithm marked as non-installable. I think that they should be also excluded from the public API documentation, otherwise it is not possible to understand which parts of API are for public use and which are internal.

Best regards, Andrey

Change History

Changed 5 years ago by mloskot

  • cc mloskot added

Changed 5 years ago by mloskot

  • owner set to mloskot
  • status changed from new to assigned

Subject: Re: [Fwd: [geos-devel] Ticket #184] Date: Tue, 6 May 2008 23:26:18 +0200 From: Sandro Santilli <strk@…> To: Mateusz Loskot <mateusz@…> References: <4820B90C.5080207@…>

On Tue, May 06, 2008 at 10:01:16PM +0200, Mateusz Loskot wrote:

Hi Sandro, Sorry I'm bothering you, but could you give me some comments to this issue below? As I see, you have intentionally removed them:  http://trac.osgeo.org/geos/changeset/1600 Is it to separate public API from private/implementation headers?

Yes, I was sick of breaking API whenever there was a need to fix a design issue (many many times). I voted myself to only maintain the C-API finally... Dunno what the current idea is, but for sure I think GEOS api is far too wide to maintain.

-- strk

Changed 5 years ago by mloskot

Folks,

Any ideas and suggestions how should we handle this issue? Please, see Andrey's report and Sandro's explanation above and let's brainstorm some solution for this.

Changed 4 years ago by pramsey

  • version set to 3.0.0
  • milestone set to 3.2.0

Andrey and others need to tell us whether they mind having the API change more than they mind missing the public headers.

Changed 4 years ago by strk

The main page of doxygen documentation is clear on the matter. It reccommends using the C api and warns about troubles with the C++ one. Dox not not mentioning what's possible to use is part of the trouble. See:  http://download.osgeo.org/geos/doxygen/

An easy "fix" could be skipping the not-installed headers, but I find it useful for internal development to have doxygen documentation for internal classes, so I'd rather have some information added to class documentation as for whether the class is accessible trough the public interface.

Changed 4 years ago by strk

  • status changed from assigned to closed
  • resolution set to fixed

Easier fix committed in r2557 (installed all headers).

Note: See TracTickets for help on using tickets.