Ticket #178 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

GEOS fails to build under GCC 4.3.0

Reported by: jey Owned by: mloskot
Priority: major Milestone:
Component: Core Version: svn-trunk
Severity: Unassigned Keywords:
Cc:

Description

Attached is a patch to allow GEOS trunk r2123 to build against GCC 4.3.0. I tested this on Linux under i686 and amd64.

Additional random note: I had to remove "-ansi -pedantic" from the configure default CXXFLAGS too, but I was using libstdc++'s parallel mode and think this is a bug in libstdc++. I'll try a build with the regular libstdc++ and look into this further.

Attachments

geos-r2123-gcc-4.3.0.patch Download (6.0 KB) - added by jey 5 years ago.
patch to allow GEOS to build under GCC 4.3.0

Change History

Changed 5 years ago by jey

patch to allow GEOS to build under GCC 4.3.0

Changed 5 years ago by mloskot

Jey,

As a word of review, the patch looks very good to me. It improves C++ code strictness and should not break compilation with compilers other than new GCC. So, I'd recommend to apply it.

Changed 5 years ago by mloskot

  • owner set to mloskot
  • status changed from new to assigned
  • component changed from Build/Install to Core
  • milestone set to 3.1

Most of Jey's fixes have been already applied (r2131)

Changed 5 years ago by mloskot

This ticket is partially a duplicate of #167

Changed 5 years ago by mloskot

  • status changed from assigned to closed
  • resolution set to fixed

As confirmed in ticket #167, after recent submission (r2143) GEOS should compile using GCC 4.3 without any problems (not counting number of warnings). Closing as fixed.

Changed 4 years ago by anonymous

  • milestone 3.1.0 deleted

Milestone 3.1.0 deleted

Note: See TracTickets for help on using tickets.