Ticket #166 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

Improper test for inlining GEOS functions (3.0.0rc4)

Reported by: dylan Owned by: mloskot
Priority: major Milestone:
Component: Core Version: svn-trunk
Severity: Significant Keywords: mingw
Cc:

Description

It seems like there is a small mistake in the test logic on line 30 of 'source/inlines.cpp' that causes some applications which use GEOS to not compile, complaining about common items not being defined. This has been brought up in several mailing  list conversations, and appears to only apply to 3.0.0rc4. The fix is documented in the linked mailing list conversation, but can be summarized as :

on line 30 of 'source/inlines.cpp' change: 

#if defined(__MINGW32__) && !defined(DLL_EXPORT)

to: 

#if !defined(__MINGW32__) || defined(__MINGW32__) && !defined(DLL_EXPORT)

Change History

Changed 5 years ago by dylan

  • version set to 3.0.0

Changed 5 years ago by mloskot

  • status changed from new to assigned
  • component changed from C API to Core
  • owner set to mloskot
  • version changed from 3.0.0 to svn-trunk
  • milestone set to 3.0.0
  • keywords mingw added

Changed 5 years ago by mloskot

  • status changed from assigned to closed
  • resolution set to fixed

As Mark  reminded this ticket has been fixed a long while ago (r1975)

Changed 4 years ago by anonymous

  • milestone 3.0.0 deleted

Milestone 3.0.0 deleted

Note: See TracTickets for help on using tickets.