Opened 6 years ago

Closed 6 years ago

#114 closed defect (fixed)

Changing port in GAST doesn't work

Reported by: rjwalker Owned by: simonp
Priority: major Milestone: v2.4.0 RC2
Component: GAST Version: v2.4.0 RC1
Keywords: Cc:

Description

SVN commit 2822 upgraded Jetty and made a number of changes to GAST. But core GAST functionality is now broken. For example:

  1. Make a fresh checkout of either trunk or 2.4 branch.
  2. Run ant to compile.
  3. Change to bin directory and start GAST.
  4. Select "Jetty" tab. Notice that the "Port" field is blank - it should show 8080.
  5. Enter a number, e.g. 9080, and Click Save. Confirmation dialog pops up.
  6. Quit GAST.
  7. Check jetty.xml and observe that the port number has not changed.

The problem is src/org/fao/gast/lib/EmbeddedSCLib.java. The constructor has not been updated to locate the port correctly in the newer configuration file syntax. What was:

        <Call name="addListener">
                <Arg>
                <New class="org.mortbay.http.SocketListener">
                        <Set name="port">8080</Set>

is now the first of two sections beginning:

    <Call name="addConnector">
      <Arg>
          <New class="org.mortbay.jetty.nio.SelectChannelConnector">
            <Set name="host"><SystemProperty name="jetty.host" /></Set>
            <Set name="port"><SystemProperty name="jetty.port" default="8080"/><
/Set>

Change History (3)

comment:1 Changed 6 years ago by ticheler

  • Milestone set to v2.4.0 RC2
  • Owner changed from geonetwork-devel@… to simonp

The Jetty panel has been removed from GAST. The Jetty configuration file (jetty.xml) will now be parsed to retrieve the port and hostname.

comment:2 Changed 6 years ago by rjwalker

The Jetty panel has been removed from GAST.

No, it hasn't. And why would you do that, anyway?

The Jetty configuration file (jetty.xml) will now be parsed to retrieve the port and hostname.

That was the case, but the update to Jetty (and thus the syntax of jetty.xml) broke this.

comment:3 Changed 6 years ago by simonp

  • Resolution set to fixed
  • Status changed from new to closed

Jetty panel removed from gast in svn rev 4418 - jetty.xml file is used to retrieve hostname and port number but this is used only to provide initial values for connection in Config->Server panel. Change port and hostname by editing jetty.xml file outside gast.

Note: See TracTickets for help on using tickets.