Changes between Initial Version and Version 1 of rfc3_commiters


Ignore:
Timestamp:
Apr 28, 2007, 10:30:23 AM (17 years ago)
Author:
warmerdam
Comment:

Ported from doxygen.

Legend:

Unmodified
Added
Removed
Modified
  • rfc3_commiters

    v1 v1  
     1= RFC 3: GDAL Commiter Guildlines =
     2
     3Author: Frank Warmerdam[[BR]]
     4Contact: warmerdam@pobox.com[[BR]]
     5Status: Adopted
     6
     7== Purpose ==
     8
     9To formalize SVN (or CVS) commit access, and specify some guidelines for
     10SVN committers.
     11
     12== Election to SVN Commit Access ==
     13
     14Permission for SVN commit access shall be provided to new developers only if
     15accepted by the GDAL/OGR Project Steering Committee.  A proposal should be
     16written to the PSC for new committers and voted on normally.  It is not
     17necessary to write an RFC document for these votes, a proposal to gdal-dev
     18is sufficient.
     19
     20Removal of SVN commit access should be handled by the same process.
     21
     22The new committer should have demonstrated commitment to GDAL/OGR and
     23knowledge of the GDAL/OGR source code and processes to the committee's
     24satisfaction, usually by reporting bugs, submitting patches, and/or actively
     25participating in the GDAL/OGR mailing list(s).
     26
     27The new committer should also be prepared to support any new feature or
     28changes that he/she commits to the GDAL/OGR source tree in future releases,
     29or to find someone to which to delegate responsibility for them if he/she
     30stops being available to support the portions of code that he/she is
     31responsible for.
     32
     33All committers should also be a member of the gdal-dev mailing list so they
     34can stay informed on policies, technical developments and release preparation.
     35
     36New commiters are responsible for having read, and understood this document.
     37
     38== Committer Tracking ==
     39
     40A list of all project committers will be kept in the main gdal directory (called COMMITERS) listing for each SVN committer:
     41
     42 * Userid: the id that will appear in the SVN logs for this person.
     43 * Full name: the users actual name.
     44 * Email address: A current email address at which the committer can be reached. It may be altered in normal ways to make it harder to auto-harvest.
     45 * A brief indication of areas of responsibility.
     46
     47== SVN Administrator ==
     48
     49One member of the Project Steering Committee will be designed the SVN
     50Administrator. That person will be responsible for giving SVN commit access
     51to folks, updating the COMMITERS file, and other SVN related management. That
     52person will need login access on the SVN server of course.
     53
     54Initially Frank Warmerdam will be the SVN Adminstrator.
     55
     56== SVN Commit Practices ==
     57
     58The following are considered good SVN commit practices for the GDAL/OGR
     59project.
     60
     61 * Use meaningful descriptions for SVN commit log entries.
     62 * Add a bug reference like "(bug 1232)" at the end of SVN commit log entries when committing changes related to a bug in bugzilla.
     63 * Changes should not be committed in stable branches without a corresponding bug id.  Any change worth pushing into the stable version is worth a bug entry.
     64 * Never commit new features to a stable branch without permission of the PSC or release manager.  Normally only fixes should go into stable branches.
     65 * New features go in the main development trunk.
     66 * Only bug fixes should be committed to the code during pre-release code freeze, without permission from the PSC or release manager.
     67 * Significant changes to the main development version should be discussed on the gdal-dev list before you make them, and larger changes will require a  RFC approved by the PSC.
     68 * Do not create new branches without the approval of the PSC.  Release managers are assumed to have permission to create a branch.
     69 * All source code in SVN should be in Unix text format as opposed to DOS text mode.
     70 * When committing new features or significant changes to existing source code, the committer should take reasonable measures to insure that the source code continues to build and work on the most commonly supported platforms (currently Linux and Windows), either by testing on those platforms directly, running buildbot tests, or by getting help from other developers working on those platforms. If new files or library dependencies are added, then the configure.in, Makefile.in, Makefile.vc and related documentations should be kept up to date.
     71
     72== Legal ==
     73
     74Commiters are the front line gatekeepers to keep the code base clear of
     75improperly contributed code.  It is important to the GDAL/OGR users,
     76developers and the OSGeo foundation to avoid contributing any code to
     77the project without it being clearly licensed under the project license.
     78
     79Generally speaking the key issues are that those providing code to be
     80included in the repository understand that the code will be released under
     81the MIT/X license, and that the person providing the code has the right
     82to contribute the code.  For the commiter themselves understanding about
     83the license is hopefully clear.  For other contributors, the commiter
     84should verify the understanding unless the commiter is very comfortable that
     85the contributor understands the license (for instance frequent contributors).
     86
     87If the contribution was developed on behalf of an employer (on work
     88time, as part of a work project, etc) then it is important that an appropriate
     89representative of the employer understand that the code will be contributed
     90under the MIT/X license.  The arrangement should be cleared with an authorized
     91supervisor/manager, etc. 
     92
     93The code should be developed by the contributor, or the code should be
     94from a source which can be rightfully contributed such as from the public
     95domain, or from an open source project under a compatible license.
     96
     97All unusual situations need to be discussed and/or documented.
     98
     99Commiters should adhere to the following guidelines, and may be personally
     100legally liable for improperly contributing code to the source repository:
     101
     102 * Make sure the contributor (and possibly employer) is aware of the contribution terms.
     103 * Code coming from a source other than the contributor (such as adapted from another project) should be clearly marked as to the original source, copyright holders, license terms and so forth.  This information can be in the file headers, but should also be added to the project licensing file if not exactly matching normal project licensing (gdal/LICENSE.txt).
     104 * Existing copyright headers and license text should never be stripped from a file.  If a copyright holder wishes to give up copyright they must do so in writing to the foundation before copyright messages are removed. If license terms are changed it has to be by agreement (written in email is ok) of the copyright holders.
     105 * When substantial contributions are added to a file (such as substantial patches) the author/contributor should be added to the list of copyright holders for the file.
     106 * If there is uncertainty about whether a change it proper to contribute to the code base, please seek more information from the project steering committee, or the foundation legal counsel.
     107 
     108== Bootstraping ==
     109
     110The following existing commiters will be considered authorized GDAL/OGR
     111committers as long as they each review the commiter guidelines, and
     112agree to adhere to them.  The SVN administrator will be responsible for
     113checking with each person. 
     114
     115 * Daniel Morissette
     116 * Frank Warmerdam
     117 * Gillian Walter
     118 * Andrey Kiselev
     119 * Alessandro Amici
     120 * Kor de Jong
     121 * Howard Butler
     122 * Lichun Wang
     123 * Norman Vine
     124 * Ken Melero
     125 * Kevin Ruland
     126 * Marek Brudka
     127 * Pirmin Kalberer
     128 * Steve Soule
     129 * Frans van der Bergh
     130 * Denis Nadeau
     131 * Oleg Semykin
     132 * Julien-Samuel Lacroix
     133 * Daniel Wallner
     134 * Charles F. I. Savage
     135 * Mateusz Loskot
     136 * Peter Nagy
     137 * Simon Perkins
     138 * Radim Blazek
     139 * Steve Halasz
     140 * Nacho Brodin
     141 * Benjamin Collins
     142 * Ivan Lucena
     143 * Ari Jolma
     144 * Tamas Szekeres