Changes between Version 2 and Version 3 of ReviewerChecklist
- Timestamp:
- Apr 22, 2014, 5:41:22 AM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
ReviewerChecklist
v2 v3 11 11 * For a OGR driver, check that the Open() method of the driver (often delegated to a Open() method of the datasource) is selective enough (i.e. it will not accept data files that are not meant for the driver), and robust enough (it will not crash for small variations w.r.t content that it would recognize). Check that it can deal with unusual filenames. For a GDAL driver, similar checks, as well for the optional Identify() method 12 12 * Functions and methods should have a selective enough namespace ("GDAL" or "OGR" prefix, or use of C++ namespace) to avoid symbol collision. 13 * Developer guidelines defined in [http://trac.osgeo.org/gdal/wiki/rfc8_devguide RFC8] should be followed. 13 14 * Check that the code is portable enough : 14 15 - at the time of writing, no C++11 features.