Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#7130 closed defect (fixed)

DXF: Proper handling of ByBlock colors, line weights, and linetypes

Reported by: Alan Thomas Owned by: Alan Thomas
Priority: normal Milestone:
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords: dxf


Currently OGR treats color 0 (ByBlock) the same as color 255 (ByLayer). This is incorrect. Objects within a block that have color 0 should inherit the color of the object that causes that block to be inlined (INSERT, or DIMENSION in the case of anonymous dimensioning blocks, or LEADER/MULTILEADER in the case of arrowheads).

It's a similar story for line weights and linetypes. Indeed, OGR often emits ByBlock as a value for the Linetype field, which is pretty useless to the end user.

As usual this issue is a lot harder to fix than it looks at the outset. There is a lot of refactoring that has to be done here. In particular I have refactored oStyleProperties to live on the feature, rather than on the layer (where it was effectively a global).

Change History (2)

comment:1 Changed 21 months ago by Alan Thomas

Resolution: fixed
Status: assignedclosed

In 40644:

DXF: Move style properties to OGRDXFFeature; handle ByBlock? colors (fixes #7130)

comment:2 Changed 21 months ago by Alan Thomas

In 40715:

DXF: Support text styles (fixes #7151); various corrections for ByBlock/ByLayer? styling (refs #7130)

Note: See TracTickets for help on using tickets.