#7077 closed enhancement (fixed)
DXF: Refactor out block insertion to its own function
Reported by: | Alan Thomas | Owned by: | warmerdam |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | OGR_SF | Version: | unspecified |
Severity: | normal | Keywords: | dxf |
Cc: |
Description
Currently the OGRDXFLayer::TranslateINSERT function is the only logic that inserts blocks. However, in the future we might want to insert blocks from other places in the code; for example, arrowheads are stored as blocks.
Some of the work I am currently doing on improving OGR's support for DXF DIMENSION and LEADER entities requires the block insertion code to be refactored out into its own function.
This patch also fixes a bug (test case supplied) where the insertion point of an INSERT entity is not transformed into the OCS, as required by the DXF specification.
Attachments (2)
Change History (6)
by , 7 years ago
Attachment: | insert-ocs-reduced.dxf added |
---|
comment:3 by , 7 years ago
Sorry about that, Even. MSVC doesn't complain about missing standard library headers, so it's very easy to miss it.
The file should display as two squares side by side