Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#6938 closed defect (fixed)

PDF support : cannot compile without any external libraries

Reported by: bugbuster Owned by: warmerdam
Priority: normal Milestone:
Component: default Version: 2.2.0
Severity: normal Keywords:
Cc:

Description

It is not possible to compile PDF support with no external dependencies. Indeed, the logic in file frmts/makefile.vc makes it impossible :

!IF DEFINED(POPPLER_LIBS) || DEFINED(PODOFO_LIBS) || DEFINED(PDFIUM_LIBS)
   !IF "$(PDF_PLUGIN)" != "YES"
      EXTRAFLAGS	=	$(EXTRAFLAGS) -DFRMT_pdf
   !ELSE
      PLUGINFLAGS	=	$(PLUGINFLAGS) -DFRMT_pdf
   !ENDIF
!ENDIF

If you suppress the first (and last) line, it is possible to add PDF support without Poppler, Podofo or PDFIUM. It simply becomes :

!IF "$(PDF_PLUGIN)" != "YES"
  EXTRAFLAGS	=	$(EXTRAFLAGS) -DFRMT_pdf
!ELSE
  PLUGINFLAGS	=	$(PLUGINFLAGS) -DFRMT_pdf
!ENDIF

N.B. : in this case, we have read-only PDF support.

Change History (2)

comment:1 Changed 4 months ago by Even Rouault

Resolution: fixed
Status: newclosed

In 39244:

Windows build: always build the PDF driver, even when none of poppler/podofo/pdfium are available, in which case it is write-only (fixes #6938, patch by bugbuster)

comment:2 Changed 4 months ago by Even Rouault

In 39245:

Windows build: always build the PDF driver, even when none of poppler/podofo/pdfium are available, in which case it is write-only (fixes #6938, patch by bugbuster)

Note: See TracTickets for help on using tickets.