Opened 2 years ago

Closed 2 years ago

#6900 closed defect (wontfix)

Should tan be atan2 in ogr_xplane_geo_utils.cpp

Reported by: Kurt Schwehr Owned by: warmerdam
Priority: normal Milestone:
Component: default Version: unspecified
Severity: normal Keywords:
Cc:

Description

Should this be atan2?

https://trac.osgeo.org/gdal/browser/trunk/gdal/ogr/ogrsf_frmts/xplane/ogr_xplane_geo_utils.cpp#L102

double track = atan (sin_diffG / denom) * RAD2DEG;

Change History (2)

comment:1 Changed 2 years ago by Even Rouault

This might result in sign differences, so perhaps atan2() could be used but the code afterwards should be fixed. I'm not sure this is worth investigating more

comment:2 Changed 2 years ago by Kurt Schwehr

Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.