swig perl non void function return garbage

[brunofriedmann]

Trying to update our openSUSE package to version 2.2.0 I receive a error check from our bot code checker about functions that are non void, but return undefine data.

swig/perl/gdal_wrap.cpp line 1828 AV* to_array_classifier(SV* classifier, int* comparison, const char error){}

This is also present in swig/include/perl/band.i line 89

I've created a patch (but please consider my knowledge of C and swig being very low). The software build correctly on our tools Patch attached for review.

[brunofriedmann]

Proposed patch to fix non-void function return garbage

[Ari Jolma]

Thanks for this. The code is indeed a bit sloppy and for new (and should be marked as experimental) methods. I'll fix these.

[Ari Jolma]

In 38636:

Perl bindings: always return something from non-void functions. Fixes #6898.

[Ari Jolma]

In 38637:

Perl bindings: always return something from non-void functions. Fixes #6898.

[brunofriedmann]

Thanks Ari, I've picked your patches in my build now, waiting next bugfix release.