Opened 7 weeks ago

Closed 7 weeks ago

Last modified 7 weeks ago

#6853 closed defect (fixed)

GRASS G_set_window => Rast_set_window

Reported by: hcho Owned by: warmerdam
Priority: normal Milestone:
Component: default Version: unspecified
Severity: normal Keywords:
Cc: martinl

Description

The GRASS GIS driver needs to be updated so that it calls Rast_[gs]et_window instead of G_[gs]et_window for GRASS 7. Please refer to the attached patch.

Attachments (1)

grass57dataset.cpp.patch (485 bytes) - added by hcho 7 weeks ago.
Patch for GRASS 7

Download all attachments as: .zip

Change History (6)

Changed 7 weeks ago by hcho

Attachment: grass57dataset.cpp.patch added

Patch for GRASS 7

comment:1 Changed 7 weeks ago by Even Rouault

From which GRASS version is this needed ? I think the current driver compiles fine with 7.0

comment:2 Changed 7 weeks ago by hcho

It compiles fine with 7 because there are both G_[gs]et_window and Rast_[gs]et_window, but the Rast_ version was added in 7 to handle the window for raster reading/writing. This issue was discussed before in https://trac.osgeo.org/gdal/ticket/2953#comment:26. G_set_window doesn't change the window for raster reading and can produce an image outside the requested region.

Last edited 7 weeks ago by hcho (previous) (diff)

comment:3 Changed 7 weeks ago by Even Rouault

Cc: martinl added

Martin, any opinion on the above ?

comment:4 Changed 7 weeks ago by Even Rouault

Resolution: fixed
Status: newclosed

In 37964:

GRASS: use Rast_get_window/Rast_set_window for GRASS 7 (patch by hcho, fixes #6853)

comment:5 Changed 7 weeks ago by Even Rouault

I've committed the patch in trunk. Would probably deserve a backport in 2.1.3 but I'd prefer having confirmation that's OK.

Note: See TracTickets for help on using tickets.