Opened 8 years ago
Closed 8 years ago
#6626 closed defect (fixed)
tigerinfo does not build
Reported by: | Kurt Schwehr | Owned by: | warmerdam |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | default | Version: | svn-trunk |
Severity: | minor | Keywords: | tiger |
Cc: |
Description
Not super critical, but eventually needs to get fixed in trunk. tigerinfo is not built by default, but it and all the other programs tucked in the tree should be built in at least one travis-ci target.
cd ogrsf_frmts/tiger make tigerinfo g++ [SNIP] -DHAVE_AVX_AT_COMPILE_TIME -DHAVE_SSSE3_AT_COMPILE_TIME -DHAVE_SSE_AT_COMPILE_TIME -g -DDEBUG -ftrapv -Wall -Wextra -Winit-self -Wunused-parameter -Wformat -Werror=format-security -Wno-format-nonliteral -Wlogical-op -Wshadow -Werror=vla -Wmissing-declarations -Wnon-virtual-dtor -Woverloaded-virtual -fno-operator-names -I.. -I../.. -I/usr/local/google/home/schwehr/src/gdal/gdal/port -I/usr/include -I/usr -I/usr/include -DGDAL_COMPILATION -c tigerinfo.cpp -fPIC -DPIC -o .libs/tigerinfo.o tigerinfo.cpp: In function 'int main(int, char**)': tigerinfo.cpp:87:12: error: 'Open' is not a member of 'OGRSFDriverRegistrar' poDS = OGRSFDriverRegistrar::Open( pszDataSource, !bReadOnly, &poDriver ); ^ tigerinfo.cpp:90:16: error: 'Open' is not a member of 'OGRSFDriverRegistrar' poDS = OGRSFDriverRegistrar::Open( pszDataSource, FALSE, &poDriver ); ^ tigerinfo.cpp:111:59: error: 'class GDALDriver' has no member named 'GetName' printf( " -> %s\n", poR->GetDriver(iDriver)->GetName() ); ^ tigerinfo.cpp: In function 'void ReportOnLayer(OGRLayer*)': tigerinfo.cpp:199:63: warning: format '%d' expects argument of type 'int', but argument 2 has type 'GIntBig {aka long long int}' [-Wformat=] printf( "Feature Count: %d\n", poLayer->GetFeatureCount() ); ^ make: *** [tigerinfo.lo] Error 1
Note:
See TracTickets
for help on using tickets.
I think tigerinfo should just be removed. Wasn't aware it existed. The source shows it is a simplified version of ogrinfo that displays in addition the TIGER version. But nobody likely care about this format now, so no point in keeping that dead code that was meant for debugging purpose.