Ticket #652 (assigned defect)

Opened 4 years ago

Last modified 4 years ago

configure.in does not detect the absence of libgif when libungif is present

Reported by: dirk@advtechme.com Assigned to: warmerdam (accepted)
Priority: high Milestone:
Component: default Version: unspecified
Severity: minor Keywords:
Cc:

Description 

configure.in does not detect the absence of libgif, although it detects the
presence of libungif.

Patch will be supplied soon.

Attachments

gdal-diff.txt (14.8 kB) - added by dirk@advtechme.com on 11/27/04 13:41:49.
Patch to fix LDFLAGS-issues, the ungif-thing and bug 670

Change History

11/05/04 13:54:30 changed by warmerdam 

Dirk,

A patch would be appreciated.

11/27/04 13:41:49 changed by dirk@advtechme.com

  • attachment gdal-diff.txt added.

Patch to fix LDFLAGS-issues, the ungif-thing and bug 670

11/29/04 13:32:11 changed by warmerdam 

Also, why the inclusion of:
+
+/*
+#include <bits/c++config.h>
+#include <complex>
+#include <cmath>

I also hate reversing the order of all the LIBS directives.  What I had
might not have been ideal, but it is very hard for me to predict what problems
reversing everything might cause.

11/29/04 13:34:14 changed by warmerdam 

Doh, I lost part of my last comment.  I started out saying that the danger
of supplying such an all encompassing patch is that it scares the pants off
me, and I am unlikely to apply it.  The first issue I raised was why
you have put in this tiff library change, but I now gather it is an effort
to work around the very long commandline, is that right?  

I am very hesitant to add this special case for the libtiff code.  It really
seems like the solution is for you to up your commandline length, or to
build some libraries (like libtiff) externally.

11/29/04 14:20:48 changed by dirk@advtechme.com 

About the long-command-line-thing:
You're right. I should have broken up in two patches, I know. Sorry.
So one part is for the long command line and the other one is for libungif.

About the reversing: I did change the order to achieve that an externally given
LDFLAGS in honored first. And because I've seen it not too often this way. I can
let the order as it is as long as a user can supply the LDFLAGS externally.

There is a bug in the patch anyways. GNUmakefile should start with:
      7 GDAL_OBJ        =       $(GDAL_ROOT)/frmts/o/*.o \
      8                         $(GDAL_ROOT)/gcore/*.o \
      9                         $(GDAL_ROOT)/port/*.o \
     10                         $(GDAL_ROOT)/alg/*.o
     11 
     12 ifeq ($(TIFF_SETTING),internal)
     13 GDAL_OBJ += $(GDAL_ROOT)/frmts/o/gdal-tiff.a
     14 endif
Otherwise builds without internal libtiff are broken. Sorry.

11/29/04 14:50:58 changed by dirk@advtechme.com 

The reason for the inclusion of commented out lines is probably because working
too late in the night. Sorry for that as well.

Regarding the command line length: It looks like a limitation of the IRIX linker.